Skip to content

Fix UCI AI review trigger for explicit review ask #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masih merged 3 commits into from
Aug 14, 2026
Merged

Fix UCI AI review trigger for explicit review ask #3921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
881897b
Fix UCI AI review trigger for explicit review ask
masih Aug 14, 2026
204b01d
Bubble up fork check fixes and be explicit about allowed team
masih Aug 14, 2026
d849a6d
Merge branch 'main' into masih/fix-ai-review-explicit-trigger
masih Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ai-assist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ on:
types: [ submitted ]
jobs:
assistant:
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.16
uses: sei-protocol/uci/.github/workflows/ai-assistant.yml@bfe76dc895ec073672fba57805ba976b55276b20
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.17
uses: sei-protocol/uci/.github/workflows/ai-assistant.yml@1d50ef2bd27c695493f254c3037eb6b78f9bb85f
permissions:
contents: read
pull-requests: write
issues: write
id-token: write
secrets: inherit
with:
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.16
uci-ref: bfe76dc895ec073672fba57805ba976b55276b20
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.17
uci-ref: 1d50ef2bd27c695493f254c3037eb6b78f9bb85f
allowed-team: 'sei-protocol/sei-core'
16 changes: 12 additions & 4 deletions .github/workflows/ai-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,25 @@ name: AI Review
on:
pull_request:
types: [ opened, ready_for_review, synchronize, reopened ]
issue_comment:
Comment thread
masih marked this conversation as resolved.
types: [ created ]
pull_request_review_comment:
types: [ created ]
pull_request_review:

@seidroid seidroid Bot Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] This workflow's output is a submitted PR review with inline comments, so these two triggers let it re-trigger itself. GitHub's recursion guard only suppresses events authored by the default GITHUB_TOKEN; the review here is posted as seidroid[bot] (a GitHub App installation token), whose actions do fire pull_request_review: submitted and pull_request_review_comment: created. Unless uci/ai-review.yml drops bot senders at this pinned SHA, the first review posted will queue another run.

Adding github.event.sender.type != 'Bot' (or !endsWith(github.actor, '[bot]')) to the job if makes the loop impossible at this level rather than relying on the called workflow's filtering. Note that ai-assist.yml sharing these triggers is not evidence this is safe — it responds to mentions and does not produce reviews or review comments, so it cannot feed its own trigger the way this one can.

types: [ submitted ]
jobs:
ai-review:
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.16
uses: sei-protocol/uci/.github/workflows/ai-review.yml@bfe76dc895ec073672fba57805ba976b55276b20
if: github.event_name != 'issue_comment' || github.event.issue.pull_request != null
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.17
uses: sei-protocol/uci/.github/workflows/ai-review.yml@1d50ef2bd27c695493f254c3037eb6b78f9bb85f
permissions:
contents: read
pull-requests: write
checks: write
id-token: write
secrets: inherit
with:
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.16
uci-ref: bfe76dc895ec073672fba57805ba976b55276b20
# See: https://github.com/sei-protocol/uci/releases/tag/v0.0.17
uci-ref: 1d50ef2bd27c695493f254c3037eb6b78f9bb85f
allowed-team: 'sei-protocol/sei-core'
enable-cursor: false # Disabled for now since there is a dedicated Bugbot flow built into Cursor currently enabled on repo.
Loading