Skip to content

✨ Constraint importing event into a different major version#2626

Merged
BelSequent merged 6 commits into
mainfrom
feat/meta-11114-contraint-imports/main
May 12, 2026
Merged

✨ Constraint importing event into a different major version#2626
BelSequent merged 6 commits into
mainfrom
feat/meta-11114-contraint-imports/main

Conversation

@eselimsen
Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings May 6, 2026 16:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

All contributors have signed the CLA. ✅
Posted by the CLA Assistant Lite bot.

Copy link
Copy Markdown
Contributor

@BelSequent BelSequent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you mentioned on the ticket the thing about the BACK_TRACE, I thought there is an opportunity to make this more user friendly:

Then endpoint already supports returning an error text + a message field, which will make more sense for a business logic like this instead of a raw error. If we do this way there is no backtrace on the UI.

check_version_compatibility does not need to return Anyhow (the backtrace), because the only invokation there is extract_semver which returns an Option, so a simple error with the text would serve and you can match this into the error field.

Unfortunately check_version_compatibility lives inside get_election_event_schema, which needs backtrace, but there is a quick workaround: I would just extract that encapsulation, and maybe add map_err() to the failure points with helpful messages.

@BelSequent BelSequent merged commit 10bc4a1 into main May 12, 2026
18 checks passed
@BelSequent BelSequent deleted the feat/meta-11114-contraint-imports/main branch May 12, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants