🐞 Keycloak OTP - Adress missing from OTP screen#2651
Open
xalsina-sequent wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Keycloak OTP (Message OTP) UI strings/templates so the OTP screen can display the destination address (phone/email), and fixes a typo in the “forgot password phone number hint” message key.
Changes:
- Update OTP title i18n strings to include the destination address via
{0}placeholders across multiple locales. - Adjust OTP login template to pass
addressinto the title message formatting. - Fix
forgotPasswrodPhoneNumberHinttypo toforgotPasswordPhoneNumberHintin the reset password template and message bundles.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/keycloak-extensions/sequent-theme/src/main/resources/theme/sequent.admin-portal/login/login-reset-password.ftl | Fixes the i18n key typo for the phone number hint on reset password screen. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/templates/verify-email.ftl | Updates title rendering (currently drops parameters) for the verify-email OTP screen. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/templates/reset-message-otp.ftl | Updates header title rendering (currently drops parameters) for reset message OTP flow. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/templates/message-otp.login.ftl | Passes address into OTP/OTL title messages so the destination is shown. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/messages/messages_tl.properties | Updates OTP/OTL title strings to include {0} and renames the forgot-password hint key. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/messages/messages_gl.properties | Updates OTP/OTL title strings to include {0} and renames the forgot-password hint key. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/messages/messages_eu.properties | Updates OTP/OTL title strings to include {0} and renames the forgot-password hint key. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/messages/messages_es.properties | Updates OTP/OTL title strings to include {0} and renames the forgot-password hint key. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/messages/messages_en.properties | Updates OTP/OTL title strings to include {0} and renames the forgot-password hint key. |
| packages/keycloak-extensions/message-otp-authenticator/src/main/resources/theme-resources/messages/messages_ca.properties | Updates OTP/OTL title strings to include {0}, renames the forgot-password hint key, and tweaks SMS instruction text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+12
| <#if section = "header"> | ||
| ${msg("messageOtp.auth.title", realm.displayName)} | ||
| ${msg("messageOtp.auth.title")} | ||
| <#elseif section = "show-username"> | ||
| <h1>${msg("messageOtp.auth.title", realm.displayName)}</h1> | ||
| <h1>${msg("messageOtp.auth.title")}</h1> |
Comment on lines
9
to
12
| <#if section = "header"> | ||
| ${msg("messageOtp.auth.title", realm.displayName)} | ||
| ${msg("messageOtp.auth.title")} | ||
| <#elseif section = "show-username"> | ||
| <h1>${msg("messageOtp.auth.codeTitle", realm.displayName)}</h1> |
| ${msg("messageOtp.auth.title", realm.displayName)} | ||
| ${msg("messageOtp.auth.title")} | ||
| <#elseif section = "show-username"> | ||
| <h1>${msg("messageOtp.auth.codeTitle", realm.displayName)}</h1> |
Contributor
Author
|
@copilot apply changes based on the comments in this thread |
…TP screens Agent-Logs-Url: https://github.com/sequentech/step/sessions/fa97714e-828d-4048-b304-985d27eb52ec Co-authored-by: xalsina-sequent <173030604+xalsina-sequent@users.noreply.github.com>
Contributor
Applied all three changes from the review thread in commit e4dbec3:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/12082