✨ IVR: Move to beyond#2659
Conversation
|
All contributors have signed the CLA. ✅ |
There was a problem hiding this comment.
Pull request overview
This PR adds the beyond repository as a git submodule and updates the devcontainer setup so the submodule can be initialized automatically (including in Codespaces), supporting the ongoing IVR work being moved into beyond.
Changes:
- Add
beyondas a git submodule in.gitmodules. - Initialize git submodules during devcontainer post-create CLI initialization.
- Reformat
.devcontainer/devcontainer.jsonand add Codespaces repository access configuration for the privatesequentech/beyondrepo.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.gitmodules |
Adds the beyond submodule definition (path/url/branch) and a note about Codespaces configuration. |
.devcontainer/scripts/init-cli.sh |
Attempts to initialize submodules during devcontainer setup, logging success/failure. |
.devcontainer/devcontainer.json |
Reformats the file and adds a Codespaces repositories entry intended to allow cloning private submodules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,5 @@ | |||
| # Note: make sure to configure codespace access in "./.devcontainer/devcontainer.json" too | |||
| if git submodule update --init --recursive --depth 1; then | ||
| echo "Submodules are successfully loaded and available in the workspace" | ||
| else | ||
| echo "Failed to init submodules, they won't be available in the workspace" |
| "cweijan.vscode-database-client2", | ||
| // Rewarp lines with Alt+Q or Cmd+Q | ||
| "stkb.rewrap", |
| // For Keycloak SPIs | ||
| "vscjava.vscode-java-pack", | ||
| // To support multiple settings file and merge them, so that our | ||
| // fworkaround to support rust analyzer works fine |
| "george-alisson.html-preview-vscode", | ||
| // Python | ||
| "ms-python.python", | ||
| // Useful to check interactions with keyloak´s DB or other SQL databases |
| "ms-python.python", | ||
| // Useful to check interactions with keyloak´s DB or other SQL databases | ||
| "cweijan.vscode-database-client2", | ||
| // Rewarp lines with Alt+Q or Cmd+Q |
| "version": "latest" | ||
| } | ||
| }, | ||
| "customizations": { |
There was a problem hiding this comment.
AFAIK the only real change is this so why the reordering of the rest of things?
"codespaces": {
"repositories": {
// Allow checking out private submodules
"sequentech/beyond": {
"contents": "read"
}
}
}
There was a problem hiding this comment.
It was json reformatting/prettifying. I believe we won't use this anymore, I can revert this change, if you like.
Parent issue: https://github.com/sequentech/meta/issues/11109