Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the smoke-test harness for Azure Functions devcontainer templates by centralizing common checks into a shared helper script and simplifying template-specific test.sh entrypoints, with small updates to the composite smoke-test action packaging.
Changes:
- Added
run-template-checks.shhelper to consolidate common template checks. - Updated all Azure Functions template
test.shscripts to call the helper instead of sourcingtest-utils.shdirectly. - Updated the smoke-test composite action to copy all test utilities into the test project and tweaked
action.ymlmetadata/steps.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/test-utils/run-template-checks.sh |
New centralized runner that sources test-utils.sh and runs template + func checks. |
test/azure-functions-python/test.sh |
Simplified to invoke centralized helper for python version check. |
test/azure-functions-powershell/test.sh |
Simplified to invoke centralized helper for pwsh version check. |
test/azure-functions-node/test.sh |
Simplified to invoke centralized helper for node version check. |
test/azure-functions-java/test.sh |
Simplified to invoke centralized helper for java version check. |
test/azure-functions-dotnet/test.sh |
Simplified to invoke centralized helper for dotnet version check. |
.github/actions/smoke-test/build.sh |
Copies all files from test/test-utils/ into the test-project directory. |
.github/actions/smoke-test/action.yml |
Adds a description and removes the internal checkout step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the smoke test scripts and supporting files to improve maintainability and consistency across template-specific tests. The main changes include consolidating test utility usage, updating test scripts to use a new helper, and minor improvements to the GitHub action configuration.
Test script refactoring and consolidation:
run-template-checks.shto centralize common test logic, reducing duplication across all template-specific test scripts. Each test script now calls this helper instead of sourcing and manually invoking functions fromtest-utils.sh.test.shfiles for dotnet, java, node, powershell, python) to use the new helper script, simplifying their structure and ensuring consistent test execution. [1] [2] [3] [4] [5]Improvements to test utility usage:
build.shto copy all files fromtest/test-utils/instead of justtest-utils.sh, ensuring that the new helper script is available in the test environment.GitHub action configuration updates: