Skip to content

docs: Fix tax provider examples - #2651

Merged
Su (sushmangupta) merged 3 commits into
mainfrom
docs/tax-provider-examples
Oct 23, 2026
Merged

Su (sushmangupta) merged 3 commits into
mainfrom
docs/tax-provider-examples

Conversation

@d-kirkland

Copy link
Copy Markdown
Contributor

Summary

  • The delivery example keys taxes with $delivery->getId(); TaxAdjustment uses each key to look up a delivery position, whose identifier comes from getIdentifier(). The edit uses $position->getIdentifier() as the key.
  • The page initializes $cartPriceTaxes as an array; TaxProviderResult types that argument as ?CalculatedTaxCollection, whose inherited constructor accepts an empty collection. The edit initializes a CalculatedTaxCollection.
  • Both registration examples use an unqualified provider class name inside a namespace; the registry keys providers by $provider::class, and the processor looks up that identifier. The edit adds a leading backslash to both class references.
  • The rule example uses cart.cartAmount and places operator outside value; CartAmountRule names the condition cartCartAmount, and the rule condition stores value as JSON. The edit uses the registered name and nests operator and amount in value.

Related links

Checklist

  • I reviewed affected links, code samples, and cross-references, including PageRef references where relevant. (Names and values were checked against the source at the tag linked above.)
  • I added or updated redirects in .gitbook.yaml if pages were moved, renamed, or deleted. (N/A, no page moved.)
  • I updated .wordlist.txt (and sorted it) if spellcheck flags new legitimate terms. (No new prose words.)
  • Any required dependent changes in downstream modules have already been merged and published. (N/A)
  • This pull request is ready for review.

Notes

  • This PR was fully AI generated and requires human review. The text was drafted by an OpenAI model (gpt-6-luna) and checked by a second OpenAI model (gpt-6.1-sol), run from a Claude Code session. It has not been merged, approved or reviewed by a person. Please verify the claims and the changed text against the source before merging.
  • Defect type: Breaks (4 of 4 changes). A reader who follows the page as written ends up with code, markup or a command that fails or does not do what the page says.
  • Codebase files this change was checked against (tag v6.7.15.1): src/Core/Checkout/Cart/Delivery/Struct/DeliveryPosition.php L37-L40; src/Core/Checkout/Cart/Delivery/Struct/DeliveryPositionCollection.php L133-L135; src/Core/Checkout/Cart/Rule/CartAmountRule.php L19-L19; src/Core/Checkout/Cart/Rule/CartAmountRule.php L46-L51; src/Core/Checkout/Cart/TaxProvider/Struct/TaxProviderResult.php L20-L24; src/Core/Checkout/Cart/TaxProvider/TaxAdjustment.php L139-L141; src/Core/Checkout/Cart/TaxProvider/TaxProviderProcessor.php L128-L134; src/Core/Checkout/Cart/TaxProvider/TaxProviderRegistry.php L22-L27; src/Core/Content/Rule/Aggregate/RuleCondition/RuleConditionDefinition.php L60-L64; src/Core/Content/Rule/RuleValidator.php L109-L114; src/Core/Framework/Struct/Collection.php L22-L29.
  • How it was found: a read-through of this page against shopware/shopware at tag v6.7.15.1, then an independent re-check by a second AI model that re-read the page and the cited source files. Please check the cited lines yourself before merging.
  • Scope: main (Shopware 6.7) only. Older docs branches are not touched.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@d-kirkland Daniel Kirkland (d-kirkland) added Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document labels Oct 22, 2026
@shopware-dev-docs-connector

shopware-dev-docs-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Completed with success.
Repository: shopware/docs
Commit: 3d405af
Preview: https://developer-documentation-n4p1z02l8-shopware-frontends.vercel.app
Workflow run: #5820

@shopware-dev-docs-connector

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Running.
Repository: shopware/docs
Commit: de02b47
Preview: Waiting for workflow logs.

1 similar comment
@shopware-dev-docs-connector

Copy link
Copy Markdown

Developer Docs healthcheck

Status: Running.
Repository: shopware/docs
Commit: de02b47
Preview: Waiting for workflow logs.

@github-actions

Copy link
Copy Markdown
Contributor

📢 Developer Announcement Recommendation

Recommendation: ❌ No Announcement Recommended

No developer announcement signals were detected.

This PR does not appear to introduce developer-facing changes that require a community announcement.

@sushmangupta
Su (sushmangupta) merged commit d07d4b2 into main Oct 23, 2026
10 checks passed
@sushmangupta
Su (sushmangupta) deleted the docs/tax-provider-examples branch October 23, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement PR created to append/modify info in the existing article Info Missed To Document Info Missed To Document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants