Repository navigation
docs: Fix tax provider examples - #2651
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Developer Docs healthcheckStatus: Completed with |
Developer Docs healthcheckStatus: Running. |
1 similar comment
Developer Docs healthcheckStatus: Running. |
Contributor
📢 Developer Announcement RecommendationRecommendation: ❌ No Announcement Recommended No developer announcement signals were detected.
|
Bojan Rajh (bojanrajh)
approved these changes
Oct 22, 2026
Lennart Tinkloh (lernhart)
approved these changes
Oct 22, 2026
Su (sushmangupta)
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$delivery->getId();TaxAdjustmentuses each key to look up a delivery position, whose identifier comes fromgetIdentifier(). The edit uses$position->getIdentifier()as the key.$cartPriceTaxesas an array;TaxProviderResulttypes that argument as?CalculatedTaxCollection, whose inherited constructor accepts an empty collection. The edit initializes aCalculatedTaxCollection.$provider::class, and the processor looks up that identifier. The edit adds a leading backslash to both class references.cart.cartAmountand placesoperatoroutsidevalue;CartAmountRulenames the conditioncartCartAmount, and the rule condition storesvalueas JSON. The edit uses the registered name and nestsoperatorandamountinvalue.Related links
tax-provider.mdL63-L65tax-provider.mdL70-L73tax-provider.mdL115-L115tax-provider.mdL142-L142tax-provider.mdL164-L164tax-provider.mdL186-L188tax-provider.mdL205-L205v6.7.15.1):TaxAdjustment.phpL139-L141:TaxAdjustmentuses each tax key to look up a delivery position.DeliveryPositionCollection.phpL133-L135:DeliveryPositionCollectionuses the position identifier as its key.DeliveryPosition.phpL37-L40:DeliveryPosition::getIdentifier()returns the position identifier.TaxProviderResult.phpL20-L24:TaxProviderResulttypes its third argument as a nullableCalculatedTaxCollection.Collection.phpL22-L29:Collectionaccepts an empty iterable by default.TaxProviderRegistry.phpL22-L27:TaxProviderRegistrystores each provider under its class name.TaxProviderProcessor.phpL128-L134:TaxProviderProcessorlooks up the provider by the stored identifier and reports an error when no provider matches.CartAmountRule.phpL19-L19:CartAmountRuleregisters the condition namecartCartAmount.CartAmountRule.phpL46-L51:CartAmountRuledefinesamountandoperatoras its condition constraints.RuleConditionDefinition.phpL60-L64:RuleConditionDefinitionstores the condition value in a JSON field.RuleValidator.phpL109-L114:RuleValidatorcreates a validation violation when the condition type is invalid.Checklist
PageRefreferences where relevant. (Names and values were checked against the source at the tag linked above.).gitbook.yamlif pages were moved, renamed, or deleted. (N/A, no page moved.).wordlist.txt(and sorted it) if spellcheck flags new legitimate terms. (No new prose words.)Notes
v6.7.15.1):src/Core/Checkout/Cart/Delivery/Struct/DeliveryPosition.phpL37-L40;src/Core/Checkout/Cart/Delivery/Struct/DeliveryPositionCollection.phpL133-L135;src/Core/Checkout/Cart/Rule/CartAmountRule.phpL19-L19;src/Core/Checkout/Cart/Rule/CartAmountRule.phpL46-L51;src/Core/Checkout/Cart/TaxProvider/Struct/TaxProviderResult.phpL20-L24;src/Core/Checkout/Cart/TaxProvider/TaxAdjustment.phpL139-L141;src/Core/Checkout/Cart/TaxProvider/TaxProviderProcessor.phpL128-L134;src/Core/Checkout/Cart/TaxProvider/TaxProviderRegistry.phpL22-L27;src/Core/Content/Rule/Aggregate/RuleCondition/RuleConditionDefinition.phpL60-L64;src/Core/Content/Rule/RuleValidator.phpL109-L114;src/Core/Framework/Struct/Collection.phpL22-L29.shopware/shopwareat tagv6.7.15.1, then an independent re-check by a second AI model that re-read the page and the cited source files. Please check the cited lines yourself before merging.main(Shopware 6.7) only. Older docs branches are not touched.🤖 Generated with Claude Code