Skip to content

Remove MyISAM requirement from docs#879

Merged
GuySartorelli merged 1 commit intosilverstripe:6.1from
RVXD:patch-1
Feb 18, 2026
Merged

Remove MyISAM requirement from docs#879
GuySartorelli merged 1 commit intosilverstripe:6.1from
RVXD:patch-1

Conversation

@RVXD
Copy link
Contributor

@RVXD RVXD commented Feb 16, 2026

Remove MyISAM requirement from docs. This is no longer needed with newer versions of InnoDB

Description

Remove part of documentation that states it is required to use MyISAM for searching. Modern InnoDB versions also supports this.

Issues

@GuySartorelli
Copy link
Member

This is no longer needed with newer versions of InnoDB

Just as a sanity check, can you please link to some docs or something that shows this is the case?

@GuySartorelli
Copy link
Member

Please also resolve the linting problems that CI has pointed out.

Note that because you haven't linked to an issue it will be difficult to track this PR after you have made changes (the PR template asks you to link to an issue along with other things that make reviewing PRs easier) - linking to an issue will make it more likely this is merged after the requested changes are made.

@RVXD
Copy link
Contributor Author

RVXD commented Feb 17, 2026

Just trying to help improve the Docs for Silverstripe, that's all.
This is not really related to any issue. The information in the docs just isn't correct.
See:
https://dev.mysql.com/doc/refman/8.4/en/innodb-fulltext-index.html
InnoDB has been supporting Fulltext for a very long time, since 2011 or so.
https://mariadb.com/resources/blog/initial-impressions-of-innodb-fulltext/
https://www.percona.com/blog/myisam-vs-innodb-full-text-search-in-mysql-5-6-part-1/

@michalkleiner
Copy link
Contributor

Created an issue for you, @RVXD

@GuySartorelli
Copy link
Member

Thanks @michalkleiner

@RVXD

Just trying to help improve the Docs for Silverstripe, that's all.
This is not really related to any issue. The information in the docs just isn't correct.

I appreciate you raising this PR.
I requested an issue specifically because the tooling we use to track contributions across repositories is really good when we track issues specifically. If we try to track PRs with the tool, things get cluttered and it's hard to see what's going on, so we made the decision to only track issues directly. This means a PR that doesn't have an associated issue is likely to get lost.

InnoDB has been supporting Fulltext for a very long time, since 2011 or so.

Thank you for providing those links, that helps a lot.

The CI failures are still there, can you please resolve them? Once those are resolved I'll be happy to merge this change.

Remove MyISAM requirement from docs. This is no longer needed with newer versions of InnoDB
@michalkleiner
Copy link
Contributor

I've squashed the commits and added DOC prefix.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your work on this, and thanks @michalkleiner for the support

@GuySartorelli GuySartorelli merged commit 83404e0 into silverstripe:6.1 Feb 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments