Fix/UI stop scrolling past last item#2593
Open
waj wants to merge 2 commits into
Open
Conversation
When pressing DOWN at the last item, the viewport was being scrolled further into blank padding space, causing real items to disappear off the top of the screen. Now the cursor simply stops at the last item.
scrollSelectionToMiddle now caps the viewport so blank padding is never visible below the last real item, showing as many items as possible while keeping the selection on screen.
Owner
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally made a fix for #2278. Now the lists don't keep scrolling when the end of the list is reached.
Also I did a small change in how the lists are initialized and centered, so there's no blank space at the bottom for lists with enough items to fill the screen.
I feel this behavior is now more familiar and matches other TUI tools with scrolling lists.
Closes #2278