fix: resolve #1950 - posting tags override inherited transaction tags#2595
Open
bomlinux92-byte wants to merge 1 commit into
Open
fix: resolve #1950 - posting tags override inherited transaction tags#2595bomlinux92-byte wants to merge 1 commit into
bomlinux92-byte wants to merge 1 commit into
Conversation
…de inherited txn tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for [BOUNTY 0] Inherited Tag Values are not Overwritten — Issue #1950
Root cause
The function in was concatenating posting tags and transaction tags without filtering out duplicates. This caused tag values to accumulate rather than override, leading to confusing behavior when filtering or pivoting on tags.
Fix
Modified to filter out inherited transaction tags whose tag names already appear in the posting's explicit tags. This ensures child-level tag specifications override parent-level ones, matching the expected behavior described in the issue.
Changes
Closes #1950