Skip to content

imp: print: beancount: convert underscores in account names to CamelCase #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waj wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −7
Open

imp: print: beancount: convert underscores in account names to CamelCase #2596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions hledger-lib/Hledger/Write/Beancount.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,9 @@ type BeancountAccountNameComponent = AccountName
-- It replaces spaces with dashes and other non-supported characters with C<HEXBYTES>;
-- prepends the letter A to any part which doesn't begin with a letter or number;
-- adds a second :A part if there is only one part;
-- and capitalises each part.
-- and capitalises each part (also capitalising each underscore-separated
-- subpart within a part and joining them, so e.g. "wells_fargo" becomes
-- "WellsFargo").
-- It also checks that the first part is one of the required english
-- account names Assets, Liabilities, Equity, Income, or Expenses, and if not
-- raises an informative error.
Expand Down Expand Up @@ -289,12 +291,9 @@ accountNameToBeancount a = b
accountNameComponentToBeancount :: AccountName -> BeancountAccountNameComponent
accountNameComponentToBeancount acctpart =
prependStartCharIfNeeded $
case T.uncons acctpart of
Nothing -> ""
Just (c,cs) ->
textCapitalise $
T.concatMap (\d -> if isBeancountAccountChar d then (T.singleton d) else T.pack $ charToBeancount d) $ T.cons c cs
T.concat $ map (textCapitalise . encodeChars) $ T.split (=='_') acctpart
where
encodeChars = T.concatMap (\d -> if isBeancountAccountChar d then T.singleton d else T.pack $ charToBeancount d)
prependStartCharIfNeeded t =
case T.uncons t of
Just (c,_) | not $ isBeancountAccountStartChar c -> T.cons beancountAccountDummyStartChar t
Expand Down
4 changes: 3 additions & 1 deletion hledger/hledger.m4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,9 @@ or this [hledger2beancount.conf](https://github.com/simonmichael/hledger/blob/ma

Aside from the top-level names, hledger will adjust your account names to make valid
[Beancount account names](https://beancount.github.io/docs/beancount_language_syntax.html#accounts),
by capitalising each part, replacing spaces with `-`, replacing other unsupported characters with `C<HEXBYTES>`,
by capitalising each part (also capitalising each underscore-separated subpart and joining them,
so e.g. `wells_fargo` becomes `WellsFargo`),
replacing spaces with `-`, replacing other unsupported characters with `C<HEXBYTES>`,
prepending `A` to account name parts which don't begin with a letter or digit,
and appending `:A` to account names which have only one part.

Expand Down
4 changes: 4 additions & 0 deletions hledger/test/print/beancount.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,23 @@ $ hledger -f- print -O beancount
>=1

# ** 2. Otherwise, accounts are modified/encoded to suit beancount, and open directives are added.
# Underscore-separated subparts within a component are capitalised and joined.
<
2000-01-01
assets 0 ABC
equity:$-€:$ 0 USD
assets:my_cash 0 ABC

$ hledger -f- print -O beancount
;option "inferred_tolerance_default" "*:0.005"
2000-01-01 open Assets:A
2000-01-01 open Assets:MyCash
2000-01-01 open Equity:C24-C20ac:C24

2000-01-01 *
Assets:A 0 ABC
Equity:C24-C20ac:C24 0 USD
Assets:MyCash 0 ABC

>=

Expand Down
Loading