Skip to content

fix: resolve bounty issue #1950 - posting tags now override inherited txn tags #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bomlinux92-byte wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: resolve bounty issue #1950 - posting tags now override inherited txn tags #2597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hledger-lib/Hledger/Data/Posting.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,14 @@ postingCommodities = map acommodity . filter (not . isMissingAmount) . amountsRa
where isMissingAmount a = acommodity a == "AUTO"

-- | Tags for this posting including any inherited from its parent transaction.
-- Explicitly-set posting tags override inherited transaction tags with the same name.
postingAllTags :: Posting -> [Tag]
postingAllTags p = ptags p ++ maybe [] ttags (ptransaction p)
postingAllTags p = postingTags ++ filteredTxnTags
where
postingTags = ptags p
txnTags = maybe [] ttags (ptransaction p)
postingTagNames = map fst postingTags
filteredTxnTags = filter ((`notElem` postingTagNames) . fst) txnTags

-- | Tags for this transaction including any from its postings (which includes any from the postings' accounts).
transactionAllTags :: Transaction -> [Tag]
Expand Down
Loading