improvement(resources): simplify list preference adapters

Author: j15z

apps/sim/app/workspace/[workspaceId]/files/files.tsx

@@ -425,7 +425,6 @@ export function Files() {
     dir: sortDirection,
     activeSort,
     onSort: applyUrlSort,
-    onClear: clearUrlSort,
   } = useUrlSort(filesSortParams, filesFilterUrlKeys)
 
   const currentListPreference = useMemo<ResourceListPreference>(
@@ -447,17 +446,9 @@ export function Files() {
         size: [...preference.filters.size],
         uploadedBy: [...preference.filters.uploadedBy],
       })
-      const defaultSort = filesListPreferenceConfig.defaultPreference.sort
-      if (
-        preference.sort.column === defaultSort.column &&
-        preference.sort.direction === defaultSort.direction
-      ) {
-        clearUrlSort()
-      } else {
-        applyUrlSort(preference.sort.column, preference.sort.direction)
-      }
+      applyUrlSort(preference.sort.column, preference.sort.direction)
     },
-    [applyUrlSort, clearUrlSort, setFileFilters]
+    [applyUrlSort, setFileFilters]
   )
 
   const {

apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx

@@ -285,7 +285,6 @@ export function Knowledge() {
     dir: sortDirection,
     activeSort,
     onSort: applyUrlSort,
-    onClear: clearUrlSort,
   } = useUrlSort(knowledgeSortParams, knowledgeUrlKeys)
 
   const currentListPreference = useMemo<ResourceListPreference>(
@@ -307,17 +306,9 @@ export function Knowledge() {
         content: [...preference.filters.content],
         owner: [...preference.filters.owner],
       })
-      const defaultSort = knowledgeListPreferenceConfig.defaultPreference.sort
-      if (
-        preference.sort.column === defaultSort.column &&
-        preference.sort.direction === defaultSort.direction
-      ) {
-        clearUrlSort()
-      } else {
-        applyUrlSort(preference.sort.column, preference.sort.direction)
-      }
+      applyUrlSort(preference.sort.column, preference.sort.direction)
     },
-    [applyUrlSort, clearUrlSort, setKnowledgeFilters]
+    [applyUrlSort, setKnowledgeFilters]
   )
 
   const {

apps/sim/app/workspace/[workspaceId]/tables/tables.tsx

@@ -256,7 +256,6 @@ export function Tables() {
     dir: sortDirection,
     activeSort,
     onSort: applyUrlSort,
-    onClear: clearUrlSort,
   } = useUrlSort(tablesSortParams, tablesUrlKeys)
 
   const currentListPreference = useMemo<ResourceListPreference>(
@@ -273,17 +272,9 @@ export function Tables() {
         rows: [...preference.filters.rows],
         owner: [...preference.filters.owner],
       })
-      const defaultSort = tablesListPreferenceConfig.defaultPreference.sort
-      if (
-        preference.sort.column === defaultSort.column &&
-        preference.sort.direction === defaultSort.direction
-      ) {
-        clearUrlSort()
-      } else {
-        applyUrlSort(preference.sort.column, preference.sort.direction)
-      }
+      applyUrlSort(preference.sort.column, preference.sort.direction)
     },
-    [applyUrlSort, clearUrlSort, setTableFilters]
+    [applyUrlSort, setTableFilters]
   )
 
   const {

apps/sim/hooks/use-resource-list-preferences.test.tsx

@@ -247,14 +247,18 @@ describe('useResourceListPreferences', () => {
     await flushEffects()
     expect(useResourceListPreferencesStore.getState()._hasHydrated).toBe(true)
 
-    act(() => result.current.commitPreference(filteredPreference))
+    act(() => result.current.setFilter('type', ['document']))
 
-    expect(applyPreference).toHaveBeenCalledWith(filteredPreference)
+    const filterPreference: ResourceListPreference = {
+      ...defaultPreference,
+      filters: { ...defaultPreference.filters, type: ['document'] },
+    }
+    expect(applyPreference).toHaveBeenCalledWith(filterPreference)
     expect(useResourceListPreferencesStore.getState().preferences).toEqual({
-      'workspace-1': { files: filteredPreference },
+      'workspace-1': { files: filterPreference },
     })
 
-    act(() => result.current.commitPreference(defaultPreference))
+    act(() => result.current.clearFilters())
 
     expect(applyPreference).toHaveBeenCalledWith(defaultPreference)
     expect(useResourceListPreferencesStore.getState().preferences).toEqual({})

apps/sim/hooks/use-resource-list-preferences.ts

@@ -19,7 +19,6 @@ interface UseResourceListPreferencesProps {
 
 interface UseResourceListPreferencesReturn {
   isReady: boolean
-  commitPreference: (preference: ResourceListPreference) => void
   setFilter: (filterKey: string, values: string[]) => void
   clearFilters: () => void
   setSort: (column: string, direction: ResourceListPreference['sort']['direction']) => void
@@ -231,7 +230,6 @@ export function useResourceListPreferences({
 
   return {
     isReady: !enabled || (pendingRestoration?.key !== key && hasUrlPreference) || readyKey === key,
-    commitPreference,
     setFilter,
     clearFilters,
     setSort,