fix(settings): gate workspace sections on the deployment the same way the sidebar does - #7476
Merged
Merged
Conversation
… the sidebar does
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR aligns direct workspace-settings route authorization with the deployment gates used by settings navigation.
Confidence Score: 5/5The PR appears safe to merge, with route and sidebar deployment gating aligned across the checked workspace sections. All resolver callers pass the required deployment shape, the shared catalog projection reproduces the sidebar’s deployment conditions, and no changed-code-triggered failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/components/settings/navigation.ts | Centralizes workspace deployment availability around shared catalog metadata without leaving stale resolver callers or divergent deployment conditions. |
| apps/sim/lib/settings/application/workspace-section-access.ts | Supplies the complete deployment shape to route authorization so direct links follow the same deployment restrictions as navigation. |
| apps/sim/components/settings/navigation.test.ts | Adds focused hosted, self-hosted, override, and BYOK navigation coverage. |
| apps/sim/lib/settings/application/workspace-section-access.test.ts | Updates route-authorization expectations for the deployment-shape contract. |
Reviews (1): Last reviewed commit: "fix(settings): gate workspace sections o..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/settings/inboxwas authorized and rendered an upgrade notice while the sidebar hid the sectionresolveWorkspaceNavigationnow takes the server-resolved deployment shape and reads each section'srequiresHosted/requiresSelfHosted/selfHostedOverridefrom the catalog, the same entry the sidebar filters on, so an unavailable section redirects to Generalself-hostandbyokrules in favor of that shared gate;byokleaves the entitlement bag since the catalog already says it is hosted-onlyType of Change
Testing
vitestfor settings navigation, the section gate, the settings pages, and the settings sidebar: 201 passingbun run type-check,bun run lint,bun run check:audits,docs-manifest:check, block-registry check all passChecklist