chore(typescript): assert native TS7 per workspace and drop a dead install exemption - #7495
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryThe PR strengthens TypeScript tooling safeguards by removing an unused install-age exemption and verifying that every declared workspace resolves a native TypeScript 7 compiler.
Confidence Score: 5/5The PR appears safe to merge; the prior workspace-discovery and repository-boundary findings are fully addressed. The audit now derives its workspace patterns from the current root manifest, checks each workspace’s nearest compiler, and stops resolution after examining the repository root. No actionable new failures or repository-rule violations remain.
|
| Filename | Overview |
|---|---|
| bunfig.toml | Removes an unused package exemption while retaining the seven-day dependency release-age gate. |
| scripts/check-native-typecheck.ts | Expands native compiler validation to all declared workspaces and correctly bounds executable lookup to the repository. |
Reviews (2): Last reviewed commit: "fix(scripts): stop the tsc resolver at t..." | Re-trigger Greptile
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Fix all with cubic | Re-trigger cubic
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Re-trigger cubic
…orkspaces from the manifest
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Re-trigger cubic
1 participant
Summary
@typescript/native-previewentry from the install age-gate allowlistThe allowlist entry was dead
bunfig.tomlexcluded@typescript/native-previewfromminimumReleaseAge, on the grounds that it only publishes nightly builds and so can never satisfy an age gate. That was true of the package, but the repo does not depend on it: the root uses@typescript/native(an alias oftypescript@^7.0.2), andnative-previewappears in nopackage.jsonand nobun.lockentry — the only two mentions in the entire repo were the exclude and its own comment.An allowlist entry that names nothing still weakens the gate, because it is a standing exemption waiting for a package of that name to appear. Removed;
bun install --frozen-lockfilestill succeeds, which is what proves nothing was relying on it.The gate itself, and its 7-day window, are unchanged.
The guard only covered the root
check:native-typecheckexists because@typescript/typescript6pulls in an alias oftypescript@6that ships its owntscbin, and bin winners are picked by lexical sort rather than dependency depth — so a baretscsilently drops to the ~10x slower JavaScript compiler unless@typescript/nativesorts ahead of it.It asserted that on
node_modules/.bin/tscalone. But every workspace'stype-checkis a baretsc --noEmit, which resolves through the nearestnode_modules/.binwalking up from that package. All 29 reach the root bin today, so the root-only assertion happened to be sufficient — but a workspace that installed anything shipping its owntscwould get a local bin that shadows the root one, in exactly the same silent way, and the audit would still pass.The guard now resolves
tscper workspace the way each script would, and names the offending package and path when one disagrees. Verified by planting a stub reportingVersion 6.0.2inapps/sim/node_modules/.bin: the previous guard passed, this one fails withapps/sim: apps/sim/node_modules/.bin/tsc reports "Version 6.0.2".Why
@typescript/typescript6staysWorth recording, since removing it would dissolve the whole bin-shadowing problem. It cannot go: four audit scripts (
check-pending-drop-tables,check-sql-date-binding,check-tool-request-boundary,check-egress-boundary) andapps/sim's Function-block runtime read the stable compiler API —createSourceFile,createScanner,forEachChild,SyntaxKind.typescript@7exposes no equivalent from its root entry point (that islib/version.cjs); its compiler API lives entirely under./unstable/*subpaths. Moving five consumers — one of which transpiles user-supplied code in production — onto a surface the package itself labels unstable is not a trade worth making for a dependency cleanup.Type of Change
Testing
bun run check:native-typecheckpasses across 29 workspaces, and fails as intended against a planted shadowing bin.bun install --frozen-lockfilesucceeds with the allowlist entry removed;bun.lockis unchanged.bun run check:audits,bunx turbo run type-check,bun run lint,bun run docs-manifest:check.Checklist