Skip to content

feat(oci-events): add native Events integration - #7544

Open
BillLeoutsakosvl346 wants to merge 1 commit into
feat/oci-foundationfrom
investigate/oci-events-integration
Open

feat(oci-events): add native Events integration#7544
BillLeoutsakosvl346 wants to merge 1 commit into
feat/oci-foundationfrom
investigate/oci-events-integration

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add six native OCI Events tools: List Rules, Get Rule, Create Rule, Update Rule, Delete Rule, and Change Rule Compartment, plus a credential-bound rule selector.
  • Reuse the OCI signing client and credentials from feat(oci): add native foundation #7444. This PR is stacked on feat/oci-foundation at 3fa59e758f5d282e95978aca7482a91a4f3dcee5, with one integration commit above it.
  • Validate structured conditions and ONS/OSS/FAAS actions, preserve replacement and ETag semantics, and return bounded documented projections. This manages OCI routing; it does not add an inbound Sim trigger.

Type of Change

  • New integration

Testing

  • Test and Build passed for 5ab6fab6626ce092801e6e2a17f44c51a18dcea1: lint, audits, generated consistency, workspace type checks, all three test shards, schema synchronization, and app build.
  • The run passed 34 Events operation tests, 24 credential-dispatch tests, and 9 selector/input tests, alongside manifest assertions and the existing suite.
  • Independent integration/selector review completed across the integration and foundation execution path. Input-budget and Create Rule option findings addressed.
  • Greptile 5/5 on this revision; review threads resolved.
  • Existing generators produced tool metadata, integration documentation and deployment catalogs. No local tests, lint, type checks or builds were run.

Checklist

  • Code follows the existing OCI integration architecture
  • Self-reviewed and independently reviewed the integration
  • GitHub tests, audits, type checks and build passing
  • Reuses NetSuiteIcon and the existing OCI provider

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 6, 2026 12:44am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a native OCI Events integration for discovering and managing event-routing rules.

  • Registers six OCI Events operations covering list, get, create, update, delete, and compartment moves.
  • Adds credential-bound rule selection, OCI request signing, input validation, bounded response projections, retry and ETag handling, generated metadata, deployment configuration, and documentation.
  • Updates the enabled-state control so Create Rule offers only valid boolean choices while Update Rule retains the optional “Keep current” choice.

Confidence Score: 5/5

The PR appears safe to merge, with the previously reported invalid Create Rule option fixed and no new actionable issues found.

Create Rule now exposes only Enabled and Disabled, both of which normalize to booleans accepted by the create schema; Update Rule alone retains “Keep current.” The other changes since the previous review are formatting and ordering adjustments without behavioral impact. The filename finding was correctly withdrawn after confirming the repository’s service-name convention.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/oci_events.ts Defines the OCI Events workflow block and now limits Create Rule’s enabled-state choices to schema-valid booleans.
apps/sim/lib/internal/oci-events/execute-tool.ts Implements authenticated internal dispatch, validation, cancellation, and stable provider-error handling.
apps/sim/lib/internal/oci-events/input.ts Defines bounded schemas for rule operations, structured conditions, actions, tags, pagination, and concurrency inputs.
apps/sim/lib/internal/oci-events/operations.ts Constructs OCI Events API requests and projects bounded rule responses and headers.
apps/sim/lib/selectors/server/providers/oci-events.ts Provides credential-bound, compartment-scoped rule discovery and detail selection.
apps/sim/lib/selectors/server/providers/oci-events.test.ts Covers selector behavior and the corrected operation-dependent enabled-state options.

Sequence Diagram

sequenceDiagram
  participant User as Workflow user
  participant Block as OCI Events block
  participant Handler as Internal tool handler
  participant Auth as Credential authorization
  participant OCI as OCI Events API
  User->>Block: Configure operation and inputs
  Block->>Handler: "Dispatch oci_events_* tool"
  Handler->>Handler: Validate bounded operation input
  Handler->>Auth: Authorize workspace credential use
  Auth-->>Handler: Authorized service-account credential
  Handler->>OCI: Send signed Events request
  OCI-->>Handler: Rule data, ETag, or mutation status
  Handler-->>Block: Return bounded structured projection
Loading

Reviews (3): Last reviewed commit: "feat(oci-events): add native Events inte..." | Re-trigger Greptile

Comment thread apps/sim/blocks/blocks/oci_events.ts Outdated
Comment thread apps/sim/blocks/blocks/oci_events.ts
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the investigate/oci-events-integration branch from 9d92dda to beb5dfb Compare September 6, 2026 00:40
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant