Skip to content

improvement(docs): clarify Entra deprovisioning and validation - #7589

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/entra-scim-lifecycle-validation
Sep 8, 2026
Merged

improvement(docs): clarify Entra deprovisioning and validation#7589
waleedlatif1 merged 2 commits into
stagingfrom
codex/entra-scim-lifecycle-validation

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Clarify Entra soft deletion, permanent deletion, and scheduled lifecycle testing without resetting change tracking.
  • Record live directory account disablement and reactivation checks; keep directory deletion and Premium group validation explicitly unverified.
  • Remove inaccurate provider timing from the SCIM removal comment. Runtime behavior is unchanged.

Type of Change

  • Documentation improvement

Testing

59 focused SCIM tests passed. Lint, all 46 audits, generated-artifact checks, and the documentation production build passed. Verified the rendered guide and all three redacted screenshots in the browser. Live disablement and reactivation were checked against the provider logs and PostgreSQL state.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing focused tests passing; no behavioral change requires new tests
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 8, 2026 7:40am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 888d4a0 into staging Sep 8, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/entra-scim-lifecycle-validation branch September 8, 2026 07:46
@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Clarifies Microsoft Entra SCIM lifecycle documentation and records the scope of live provider validation.

  • Distinguishes soft deletion, permanent deletion, and app unassignment behavior.
  • Explains how provisioning restarts and configuration changes affect scheduled lifecycle testing.
  • Records successful disablement/reactivation checks while leaving directory deletion and Premium group provisioning explicitly unverified.
  • Removes an inaccurate provider-timing claim from a source comment without changing runtime behavior.

Confidence Score: 5/5

The PR appears safe to merge; no outstanding correctness, security, or repository-rule issues were identified.

There are no changes since the previous review and no accepted new findings. The prior UI-setting thread was resolved after waleedlatif1 explained that the documented Entra Properties page exposes “Skip out of scope deletions” directly and that the embedded scope screenshot shows the setting.

Important Files Changed

Filename Overview
apps/docs/content/docs/platform/enterprise/scim/entra.mdx Expands Entra deprovisioning guidance, scheduled-cycle instructions, and lifecycle troubleshooting.
apps/sim/ee/scim/TESTING.md Updates the provider-validation record to distinguish verified disablement/reactivation from unverified deletion and group provisioning.
apps/sim/ee/scim/lib/application/users/deprovision-user.ts Removes inaccurate provider-specific timing from documentation comments without changing executable behavior.

Reviews (2): Last reviewed commit: "improvement(docs): clarify Entra deprovi..." | Re-trigger Greptile

Comment thread apps/docs/content/docs/platform/enterprise/scim/entra.mdx
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile Please re-evaluate the resolved UI-setting comment against the embedded scope screenshot and reply. The current Entra Properties page exposes the setting directly.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant