improvement(docs): clarify Entra deprovisioning and validation - #7589
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryClarifies Microsoft Entra SCIM lifecycle documentation and records the scope of live provider validation.
Confidence Score: 5/5The PR appears safe to merge; no outstanding correctness, security, or repository-rule issues were identified. There are no changes since the previous review and no accepted new findings. The prior UI-setting thread was resolved after waleedlatif1 explained that the documented Entra Properties page exposes “Skip out of scope deletions” directly and that the embedded scope screenshot shows the setting.
|
| Filename | Overview |
|---|---|
| apps/docs/content/docs/platform/enterprise/scim/entra.mdx | Expands Entra deprovisioning guidance, scheduled-cycle instructions, and lifecycle troubleshooting. |
| apps/sim/ee/scim/TESTING.md | Updates the provider-validation record to distinguish verified disablement/reactivation from unverified deletion and group provisioning. |
| apps/sim/ee/scim/lib/application/users/deprovision-user.ts | Removes inaccurate provider-specific timing from documentation comments without changing executable behavior. |
Reviews (2): Last reviewed commit: "improvement(docs): clarify Entra deprovi..." | Re-trigger Greptile
|
@greptile Please re-evaluate the resolved UI-setting comment against the embedded scope screenshot and reply. The current Entra Properties page exposes the setting directly. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
59 focused SCIM tests passed. Lint, all 46 audits, generated-artifact checks, and the documentation production build passed. Verified the rendered guide and all three redacted screenshots in the browser. Live disablement and reactivation were checked against the provider logs and PostgreSQL state.
Checklist