Skip to content

feat(network): add organization-specific HTTPS egress - #7807

Merged
waleedlatif1 merged 5 commits into
stagingfrom
codex/dedicated-https-egress
Sep 14, 2026
Merged

waleedlatif1 merged 5 commits into
stagingfrom
codex/dedicated-https-egress

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Route supported server HTTPS requests through an organization-owned gateway using the existing validated HTTP and connector retry helpers. Keep direct behavior when routing is unconfigured and reject managed-route failures without a direct fallback.
  • Bind requests to canonical organization ownership across application operations, connector jobs, workflow execution, webhook setup and local Function HTTP callbacks. Preserve native database, remote sandbox and unsupported SDK network paths.
  • Combine session policies and read-only outbound IPs under Security, using existing settings components, contracts and authorization. Document coverage and exclusions.

Type of Change

  • New feature

Testing

  • 1,558 focused routing, HTTP security, MCP and ownership tests passed, including real TLS CONNECT under Node and Bun.
  • Broad connector and execution regression run: 3,768 passed, one existing skip. Additional pre-execution regression run: 377 passed. These runs overlap.
  • Fresh independent audit added regressions for streaming timeout/status parity, queued enrichment ownership, webhook setup retries and reused worker callback isolation. All focused checks passed.
  • Type checking, lint, all 46 audits, block-registry and generated docs checks passed after the audit fixes.
  • Verified the Security page and docs locally, including copying a synthetic IP allowlist entry.
  • Measured the settings dependency graph against clean staging: 10 modules added; refreshed only that route's baseline.

Rollout

Deploy and verify the gateway before enabling an organization. App and background workers need the private gateway catalog, credentials and matching policy. This change does not activate routing. AWS SDK, native database and remote sandbox connections retain their existing paths; Google Drive, Fireflies, Google Workspace directory discovery and Atlassian OAuth site discovery keep their existing paths; OAuth and other SDK coverage must be verified separately.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 14, 2026 6:28am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding actionable findings.

Summary

  • Propagates canonical organization ownership through workflow execution, webhook jobs, connectors, MCP, data drains, and supported HTTP request paths.
  • Adds gateway configuration, routing context, transport, validation, retry, and security coverage.
  • Introduces organization network settings and consolidates session policies and outbound IP information under Security.
  • Documents supported connections, exclusions, availability, and fail-closed behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Application or background operation] --> B[Resolve canonical organization ownership]
    B --> C{Organization route configured?}
    C -->|No| D[Existing direct HTTPS path]
    C -->|Yes| E[Organization-owned gateway]
    E --> F[Validated HTTPS destination]
    E -->|Unavailable or rejected| G[Fail request without direct fallback]
Loading

Reviews (6) · Last reviewed commit: "chore(network): keep routing result type..."

Comment thread apps/sim/hooks/queries/organization-network.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps Please re-review after the query-key finding response. The feature only has a detail query; all → details() → detail(organizationId) matches the repository requirement and existing workspaceHostKeys/linkPreviewKeys.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 09239ca into staging Sep 14, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/dedicated-https-egress branch September 14, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant