SK-2706: fix README/samples gaps and add API reference doc - #196
Merged
saileshwar-skyflow merged 1 commit intoJun 10, 2026
Merged
Conversation
- Fix DetokenizeRequest code blocks to use DetokenizeData struct - Fix UpdateRequest to use Data map instead of Id/Values - Fix GetRequest/GetOptions: move ColumnName/ColumnValues to GetOptions - Fix WithVaultConfig → WithVaults in custom headers example - Add InsertOptions, DetokenizeOptions, GetOptions field tables - Add Client management section with all 13 Skyflow instance methods - Add SkyflowError methods table and MaskingMethod/Transcription enums - Fix signed_token_generation.go: pass credString not filePath to GenerateSignedDataTokensFromCreds - Add docs/api_reference.md covering full Go SDK v2 public API surface Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
GoSec Findings: No issues found, Good to merge. |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Devesh-Skyflow
approved these changes
Jun 9, 2026
aadarsh-st
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DetokenizeRequest,UpdateRequest, andGetRequest/GetOptionscode blocks to match actual struct definitions; fixWithVaultConfig→WithVaultsin the custom headers exampleInsertOptions,DetokenizeOptions,GetOptions; add Client management section (13 Skyflow instance methods); addSkyflowErrormethods table; addMaskingMethodandDetectOutputTranscriptionsenum docssigned_token_generation.go— passcredString(notfilePath) toGenerateSignedDataTokensFromCredsdocs/api_reference.md— full Go SDK v2 API reference covering client methods, config classes, all request/response/options structs, helper types, enums, service account utilities, and error handling; mirrors the Java SDK'sdocs/api_reference.mdstructure