SK-3133 Add unary vs. bulk guidance and concurrency sizing formula to flowvault README - #432
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
Coverage 90.99% 90.99%
- Complexity 0 545 +545
==========================================
Files 174 174
Lines 7350 7350
Branches 1013 1013
==========================================
Hits 6688 6688
Misses 437 437
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
9f30e9c to
e20ad10
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
e20ad10 to
360236d
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
360236d to
5775b56
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
New top-level section (after VaultController -- Unary operations, before Bulk Insert) covering: - Unary vs Bulk: when to use each, mirroring the structural comparison table already in the README with practical decision guidance. - The N < batchSize trap where bulk resolves to concurrency=1 with none of the batching benefit. - Concurrency guidelines: a starting-point sizing formula (N_cpu x U_cpu x (1 + W/C)) for ..._CONCURRENCY_LIMIT, with guidance to benchmark and raise incrementally rather than jump to the formula's theoretical max. Also renames the existing structural comparison heading from "Unary vs. bulk" to "Unary vs. bulk Parity" to disambiguate it from the new guidance section's title. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5775b56 to
3e78865
Compare
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
1 participant
What
Documents two things the flowvault README didn't cover yet:
N < batchSizetrap where bulk'sconcurrencyresolves to 1 regardless of..._CONCURRENCY_LIMIT, so it gets none of the batching benefit but still pays the bulk machinery's overhead.concurrency ≈ N_cpu × U_cpu × (1 + W/C)) with guidance to treat it as a baseline to benchmark from, not a final answer, and to raise..._CONCURRENCY_LIMITincrementally while watching latency rather than jumping to the formula's theoretical max.Both sections summarize findings from an SK-3133 performance investigation into unary/bulk connection-pool and concurrency behavior under load.
Where
## Sizing a concurrency limitsubsection at the end of Batching and concurrency.## Choosing between unary and bulksubsection after the existing structural Unary vs. bulk comparison table.No code changes — README only.
🤖 Generated with Claude Code