Skip to content

SK-3015-gitleaks-detection-fix - #433

Open
skyflow-himanshupal wants to merge 5 commits into
mainfrom
himanshupal/SK-3015-gitleaks-detection-multiple-secret-exposures-identified-across-repository-skyflow-java
Open

skyflow-himanshupal wants to merge 5 commits into
mainfrom
himanshupal/SK-3015-gitleaks-detection-multiple-secret-exposures-identified-across-repository-skyflow-java

Conversation

@skyflow-himanshupal

Copy link
Copy Markdown
Collaborator

Resolves Gitleaks security scan failures by removing hardcoded token values from files and example code in README.md.

Why

  • Security Compliance: Automated Gitleaks scans detected hardcoded tokens and high-entropy secret patterns in test suites and documentation.
  • Underlying Issue: Mock credentials and sample tokens used in tests and README.md triggered security scanner alerts.
  • Intent: Clear CI/CD security checks while adhering to proper secret handling practices.

Goal

  • Intended Outcome: Pass all automated Gitleaks scans in CI/CD pipelines.
  • Working Functionality: Ensure tests continue to run properly using sanitized dummy placeholders or mock environment variables, and README.md displays safe example tokens.
  • Non-Goals: Modifying core production application logic or secret rotation (as exposed values were only test/example tokens).

Testing

  • Only the hard coded tokens were changed and no additional unit tests are required.
  • Deployment Concerns: None. No production code logic was altered.

Tech Debt

  • Addressing Tech Debt: Reduces security tech debt by removing hard coded credentials from documentation and tests, setting a clean pattern for future code examples.

@github-actions

Copy link
Copy Markdown

Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions

Copy link
Copy Markdown

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions

Copy link
Copy Markdown

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions

Copy link
Copy Markdown

Gitleaks Findings: No secrets detected. Safe to proceed!

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.99%. Comparing base (24ad863) to head (2cb13fb).

Additional details and impacted files
@@            Coverage Diff             @@
##               main     #433    +/-   ##
==========================================
  Coverage     90.99%   90.99%            
- Complexity        0      545   +545     
==========================================
  Files           174      174            
  Lines          7350     7350            
  Branches       1013     1013            
==========================================
  Hits           6688     6688            
  Misses          437      437            
  Partials        225      225            
Flag Coverage Δ
common 89.15% <ø> (ø)
flowvault 87.93% <ø> (ø)
skyvault 94.95% <ø> (ø)
unittests-flowvault 89.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Module: common 89.15% <ø> (ø)
Module: skyvault 94.95% <ø> (ø)
Module: flowvault 87.93% <ø> (ø)
Service Account 87.36% <ø> (ø)
Vault Data 90.81% <ø> (ø)
Vault Tokens 99.03% <ø> (ø)
Vault Connection 100.00% <ø> (ø)
Vault Controller 82.75% <ø> (ø)
Detect 100.00% <ø> (ø)
Audit 100.00% <ø> (ø)
BIN Lookup 100.00% <ø> (ø)
Config 96.26% <ø> (ø)
Utils 90.36% <ø> (ø)
Errors 100.00% <ø> (ø)
Enums 100.00% <ø> (ø)
Logs 95.60% <ø> (ø)
Files with missing lines Coverage Δ
...src/main/java/com/skyflow/utils/BaseConstants.java 0.00% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ad863...2cb13fb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions

Copy link
Copy Markdown

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@github-actions

Copy link
Copy Markdown

Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions

Copy link
Copy Markdown

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

@skyflow-himanshupal
skyflow-himanshupal requested review from skyflow-bharti and removed request for Devesh-Skyflow September 15, 2026 12:25
@github-actions

Copy link
Copy Markdown

Gitleaks Findings: No secrets detected. Safe to proceed!

@github-actions

Copy link
Copy Markdown

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant