Skip to content

Remove redundant idle state from batch generator#112

Merged
Connor1996 merged 1 commit intoskyzh:mainfrom
Connor1996:codex/tiny-llm-batch-slot-state
Apr 12, 2026
Merged

Remove redundant idle state from batch generator#112
Connor1996 merged 1 commit intoskyzh:mainfrom
Connor1996:codex/tiny-llm-batch-slot-state

Conversation

@Connor1996
Copy link
Copy Markdown
Collaborator

@Connor1996 Connor1996 commented Apr 12, 2026

What changed

  • Removed the separate is_idle tracking from src/tiny_llm/batch.py.
  • Switched progress reporting and loop guards to treat decode_requests[i] is None as the source of truth for slot occupancy.
  • Kept the starter implementation aligned with the same slot-state model already used in the reference implementation.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@Connor1996 Connor1996 changed the title [codex] remove redundant idle state from batch generator Remove redundant idle state from batch generator Apr 12, 2026
@Connor1996 Connor1996 marked this pull request as ready for review April 12, 2026 17:55
@Connor1996 Connor1996 merged commit 68b978c into skyzh:main Apr 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant