fix: harden remote terminal protocol and UX - #1671
Draft
rixzkiye wants to merge 49 commits into
Draft
Conversation
This was referenced Aug 8, 2026
…st attach, wired recovery
rixzkiye
force-pushed
the
feat/terminal/6-hardening
branch
from
August 11, 2026 00:03
00e8012 to
2f62e0e
Compare
rixzkiye
marked this pull request as draft
August 11, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer 6 of 6, stacked on #1670. This is the final protocol-v3, security/reliability, and UX hardening layer for the experimental default-off remote terminal.
Final guarantees
Latest audit fixes — 2026-08-11
fix(cli): make terminal persistence queues recoverablefix(app): fence terminal work across detachfix(server): harden terminal writer lease handlingfix(app): bound terminal attach bufferingThis layer contains 24 atomic commits relative to #1670: the original 20 protocol/UI hardening commits plus the four audit fixes above.
Validation — 2026-08-11
pnpm --filter happy test— 88 files / 831 tests passed, including 5 real tmux tests.pnpm --filter happy-app typecheck— passed.origin/main(9.65s), confirming it is not introduced by this stack.git diff --check— passed.origin/main— clean.Review this layer
Unique diff: rixzkiye/happy@feat/terminal/5-docs...feat/terminal/6-hardening
Stack workflow
Because these contributor branches live in a fork and I do not have push access to
slopus/happy, GitHub requires every upstream PR to targetmain. Descendant PRs therefore show cumulative diffs.Only the first unmerged layer is ready for review. Later layers stay draft. After each parent lands, I will restack descendants onto the updated
mainbefore promoting the next PR; this remains correct whether maintainers rebase-merge or squash-merge.Merge order: #1666 → #1667 → #1668 → #1669 → #1670 → #1671.
Known release boundary: hosted workflows still require maintainer approval, and physical iOS/Android/Web smoke testing remains separate from local code/test proof.