[all] Fix float compilation#6115
Merged
fredroy merged 3 commits intoMay 27, 2026
Merged
Conversation
Collaborator
|
[ci-depends-on] detected during build #1. To unlock the merge button, you must
|
bakpaul
added
pr: fix
fredroy
approved these changes
May 18, 2026
alxbilger
reviewed
May 19, 2026
Collaborator
|
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
bakpaul
added
pr: status ready
Collaborator
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
fredroy
force-pushed
the
26_05_fix_float_compilation
branch
from
dd51fbe to
f2cf6f9
Compare
Contributor
|
[ci-build][with-all-tests] |
Collaborator
|
[ci-depends-on] detected during build #5. All dependencies are merged/closed. Congrats! 👍 |
Collaborator
|
[ci-depends-on] detected during build #6. All dependencies are merged/closed. Congrats! 👍 |
…nent/collision/detection/intersection/CCDTightInclusionIntersection.cpp Co-authored-by: Alex Bilger <alxbilger@users.noreply.github.com>
fredroy
force-pushed
the
26_05_fix_float_compilation
branch
from
f2cf6f9 to
3e1d680
Compare
Collaborator
|
[ci-depends-on] detected during build #7. All dependencies are merged/closed. Congrats! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of testing a CUDA PR I compiled SOFA in float. These where the required changes.
I left out all of the SoftRobotic suite (SoftRobots, SoftRobots.Inverse and MOR) because it touched to critical part such as solvers. I guess that if one day we really want to compile it in float we'll have to take the time to clean them properly.
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/229]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/611]
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if