[Simulation.Core] WorkerThread: fix memory leak/resource retention#6125
Open
fredroy wants to merge 2 commits into
Open
[Simulation.Core] WorkerThread: fix memory leak/resource retention#6125fredroy wants to merge 2 commits into
fredroy wants to merge 2 commits into
Conversation
bd2ff79 to
ef20bb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WorkerThread, the task destructor was commented. (???)
As of now, the task is only deallocated in memory but the dtor is not called thus its resources are not freed -> memory leak
For now, I am just adding a test illustrating/proving the bug and then will push the fix later
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if