Replace deprecated defaultIndexMethod usage with a compiler pass - #152
Open
HypeMC wants to merge 1 commit into
Open
Replace deprecated defaultIndexMethod usage with a compiler pass#152HypeMC wants to merge 1 commit into
defaultIndexMethod usage with a compiler pass#152HypeMC wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #152 +/- ##
============================================
+ Coverage 97.40% 97.44% +0.03%
- Complexity 499 508 +9
============================================
Files 62 63 +1
Lines 1388 1409 +21
============================================
+ Hits 1352 1373 +21
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 📝
Symfony 8.1 deprecates the
defaultIndexMethodoption oftagged_locator()in favor of the#[AsTaggedItem]attribute. That attribute is not a viable replacement here, the locator index comes from the public staticfor()method onTargetResolverInterfaceandValuesResolverInterface.A new
ResolveTaggedLocatorIndexPasscallsfor()itself during compilation and stamps the result onto eachpurgatory.target_resolverandpurgatory.route_param_value_resolvertag as aforattribute, which thetagged_locator()calls now use viaindexAttribute: 'for'.Checklist ✅