-
Notifications
You must be signed in to change notification settings - Fork 192
chore(web): Improve error messages for file loading errors #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): Improve error messages for file loading errors #665
Conversation
WalkthroughThe pull request updates the CHANGELOG with an entry about improved error messages in the file source API and refactors error handling in the CodePreviewPanel component to provide distinct error messages for separate service failures instead of a single generic error. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.md (1)
16-18: Align Unreleased section with Keep a Changelog conventions and fix capitalizationTo stay consistent with the rest of this file and the Keep a Changelog categories, consider using
### Changedinstead of### Updated, and capitalize “API”:-### Updated -- Improved error messages in file source api. [#665](https://github.com/sourcebot-dev/sourcebot/pull/665) +### Changed +- Improved error messages in file source API. [#665](https://github.com/sourcebot-dev/sourcebot/pull/665)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)packages/web/src/app/[domain]/browse/[...path]/components/codePreviewPanel.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/web/src/app/[domain]/browse/[...path]/components/codePreviewPanel.tsx (2)
packages/web/src/lib/utils.ts (1)
isServiceError(430-436)packages/mcp/src/utils.ts (1)
isServiceError(4-10)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
Improving error messaging for source file loading to help diagnose #664. This PR also changes the service error wrapper (
sew) to return a generic error message for unexpected exceptions (i.e., any exception other than a explicitly thrownServiceErrorException) to avoid leaking any potential sensitive information to the client.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.