Skip to content

refactor(all-services): pin widdershins as a devDependency instead of npx in the three services - #125

Merged
yeshamavani merged 1 commit into
masterfrom
GH-124
Jul 13, 2026
Merged

refactor(all-services): pin widdershins as a devDependency instead of npx in the three services#125
yeshamavani merged 1 commit into
masterfrom
GH-124

Conversation

@Sourav-kashyap

@Sourav-kashyap Sourav-kashyap commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

pin widdershins as a devDependency instead of npx in the three services

GH-124

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build :

Screenshot 2026-06-24 at 2 30 33 PM

Test :

Screenshot 2026-06-24 at 2 32 26 PM

… npx in the three services

pin widdershins as a devDependency instead of npx in the three services

GH-124
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Updates AWS SDK dependencies to latest patch versions (EventBridge 3.1075.0, SQS 3.1075.0) and related downstream packages, plus adds widdershins as a direct dependency for API documentation generation.

Review Focus:

  • The AWS SDK version bumps are routine patch updates with no breaking changes indicated
  • Key concern: widdershins (API doc generator) added as direct dependency instead of using npx - verify this doesn't introduce unnecessary production bloat (it should be devDependency only)
  • Removal of fast-xml-parser from @aws-sdk/xml-builder dependencies - confirm this doesn't break XML parsing in AWS SDK operations

Start review at: package.json files in the three service directories. These show the explicit addition of widdershins as a dependency and the npm script changes from npx widdershins to direct widdershins command, which is the most visible and functional change in this PR.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@yeshamavani yeshamavani left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rectify the PR title

@Sourav-kashyap Sourav-kashyap changed the title refactor(all-services): pin widdershins as a devDependency instead of… refactor(all-services): pin widdershins as a devDependency instead of npx in the three services Jul 10, 2026
@yeshamavani
yeshamavani merged commit 2738418 into master Jul 13, 2026
6 checks passed
@yeshamavani
yeshamavani deleted the GH-124 branch July 13, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(docs): pin widdershins as a devDependency instead of npx in the three services

2 participants