This repository was archived by the owner on Oct 16, 2020. It is now read-only.
fix(logging): do not use JSON.stringify to Error object#666
Open
Milly wants to merge 1 commit intosourcegraph:masterfrom
Open
fix(logging): do not use JSON.stringify to Error object#666Milly wants to merge 1 commit intosourcegraph:masterfrom
Milly wants to merge 1 commit intosourcegraph:masterfrom
Conversation
the result of `JSON.stringify(new Error('msg'))` is `{}`.
pass the `Error` object to logger as it is.
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 82.40% 82.59% +0.18%
==========================================
Files 15 15
Lines 2126 2126
Branches 509 448 -61
==========================================
+ Hits 1752 1756 +4
+ Misses 364 360 -4
Partials 10 10
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the result of
JSON.stringify(new Error('msg'))is{}.pass the
Errorobject to logger as it is.