Implement forEachSplat and getBoundingBox for PagedSplats#324
Open
mrxz wants to merge 1 commit intosparkjsdev:mainfrom
Open
Implement forEachSplat and getBoundingBox for PagedSplats#324mrxz wants to merge 1 commit intosparkjsdev:mainfrom
mrxz wants to merge 1 commit intosparkjsdev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
forEachSplatmethod into theSplatSourceinterface, ensuring it works acrossPackedSplats,ExtSplatsandPagedSplats. This allows theSplatMesh.forEachSplatandSplatMesh.getBoundingBoxmethods to work for paged splats (see #317).These implementations are somewhat unintuitive for paged splats, as they depend on which splat pages happen to be loaded. This might confuse users, though arguably the current behaviour of no-op for
forEachSplatsisn't intuitive either.