Skip to content

Add regression test for circular require across load orders #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lineoffligbot wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add regression test for circular require across load orders #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/test_load_order.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# frozen_string_literal: true

require File.expand_path('helper', File.dirname(__FILE__))

# Regression test for #65 and #66
# no "circular require" warning should appear for any load order of the gem's entry points.
class TestLoadOrder < Test::Unit::TestCase
LIB = File.expand_path('../lib', File.dirname(__FILE__))

[
['http/cookie'],
['http/cookie_jar'],
['http-cookie'],
['http/cookie', 'http/cookie_jar'],
['http/cookie_jar', 'http/cookie']
].each_with_index do |requires, i|
define_method("test_no_circular_require_#{i}") do
script = requires.map { |r| "require #{r.inspect}" }.join('; ')
cmd = [RbConfig.ruby, '-w', "-I#{LIB}", '-e', script]
output = Bundler.with_unbundled_env { IO.popen(cmd, err: %i[child out], &:read) }
assert_false(output.include?('circular require'), "warning for `#{script}`:\n#{output}")
end
end
end