Skip to content

Disable bundler cache in push_gem.yml#76

Open
connorshea wants to merge 2 commits into
sparklemotion:masterfrom
connorshea:patch-1
Open

Disable bundler cache in push_gem.yml#76
connorshea wants to merge 2 commits into
sparklemotion:masterfrom
connorshea:patch-1

Conversation

@connorshea

Copy link
Copy Markdown

For the sake of safety, to avoid potential cache poisoning attacks. It's unlikely, but the cache also saves very little time here, so I think it's worth doing.

For the sake of safety, to avoid potential cache poisoning attacks. It's unlikely, but the cache also saves very little time here, so I think it's worth doing.
@connorshea connorshea requested a review from knu as a code owner May 26, 2026 22:46
Otherwise the patch breaks the workflow, I didn't realize the bundler-cache value was the only reason `bundle install` ran 🙃
@connorshea

Copy link
Copy Markdown
Author

Added an explicit bundle install step so release-gem will work, I didn't realize bundler-cache was the only way to get setup-ruby to run bundle install 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant