Open
Conversation
CarolineDenis
approved these changes
Mar 4, 2026
alesan99
reviewed
Mar 4, 2026
Contributor
alesan99
left a comment
There was a problem hiding this comment.
- See that is the request, in the network tab, in the body of the request the discipline being sent is the current discipline of the current collection, not the discipline related to the tree. See screenshot for example.
- If you are able, check the TaxonTreeDef record that was created in the database, to make sure that it was added to the correct discipline.
I haven't fully tested this PR, but it seems to be working so far 👍
specifyweb/frontend/js_src/lib/components/TreeView/CreateTree.tsx
Outdated
Show resolved
Hide resolved
bhumikaguptaa
approved these changes
Mar 4, 2026
Collaborator
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- Watch it until completion and verify notification is received that it has been created.
- See that is the request, in the network tab, in the body of the request the discipline being sent is the current discipline of the current collection, not the discipline related to the tree. See the screenshot for example.
It works as expected. I received the creation and completion notification. I tried it by adding Ichthyology and Entomology to the Botany Discipline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7776
This fixes a bug where creating/importing a default tree from Tree Viewer could create the tree under the wrong discipline. For example, using the downloadable tree metadata discipline like botany instead of the logged-in collection’s discipline.
In tree view CreateTree code, send disciplineName from getSystemInfo().discipline, instead of resource.discipline from the selected default-tree file.
In create_default_tree_view, always resolve tree discipline from the destination collection.discipline. Use the resolved destination collection.id when queuing create_default_tree_task.
Checklist
self-explanatory (or properly documented)
Testing instructions