Unblock login after new discipline from config tool creation#7781
Merged
acwhite211 merged 4 commits intomainfrom Mar 5, 2026
Merged
Unblock login after new discipline from config tool creation#7781acwhite211 merged 4 commits intomainfrom
acwhite211 merged 4 commits intomainfrom
Conversation
5 tasks
CarolineDenis
approved these changes
Mar 4, 2026
alesan99
approved these changes
Mar 4, 2026
Contributor
alesan99
left a comment
There was a problem hiding this comment.
- See that you can login while the discipline and it's tree are still being created.
- Want sometime for all the background processes to end for creating the new collection, and the try logging in to the new collection.
Looks good! 👍
Logins work correctly and new collections appear after a while. I wasn't able to trigger the database setup loading page through the config tool, so that works.
alesan99
reviewed
Mar 4, 2026
bhumikaguptaa
approved these changes
Mar 4, 2026
Collaborator
bhumikaguptaa
left a comment
There was a problem hiding this comment.
Checking login after created a new discipline:
- See that you can login while the discipline and it's tree are still being created.
Checking login after creating a new collection:
- Confirm that the new collection is not yet available as an option of login as.
- Want sometime for all the background processes to end for creating the new collection, and the try logging in to the new collection.
Everything works as expected, I didn't run into any errors. I was able to view the new collection without logging out and back in.
emenslin
approved these changes
Mar 5, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- See that you can login while the discipline and it's tree are still being created.
- Confirm that the new collection is not yet available as an option of login as.
- Wait sometime for all the background processes to end for creating the new collection, and the try logging in to the new collection.
Looks good, I didn't run into any issues!
grantfitzsimmons
approved these changes
Mar 5, 2026
Member
grantfitzsimmons
left a comment
There was a problem hiding this comment.
- For dev testers, check the logs from the worker container to make sure no tree creation task is still running when the UI changes from the database loading page to the login page.
- See that you can login while the discipline and it's tree are still being created.
- Confirm that the new collection is not yet available as an option of login as.
- Wait sometime for all the background processes to end for creating the new collection, and the try logging in to the new collection.
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7774
Prevent a new discipline being created in the background from the user being able to login to a collection from an already existing discipline. Also, this solution needs to preserve the functionality of preventing the user from logging into a new collection before it is fully completed.
It seems this issue of new disciplines is being caused as a side-effect of the solution to preventing new collections from being used before they were fully ready.
While a new discipline was being created, background config Celery tasks were treated as global “setup in progress.” That made the login page show Guided Setup for users and could block login/collection switching even for unaffected collections.
The setup_progress busy variable now reflects only true initial database setup, not generic config tasks. Config-task blocking is collection aware, so only newly created collections are blocked, and existing collections and disciplines remain available.
Checklist
self-explanatory (or properly documented)
Testing instructions
Setup Tool (This section is for Dev Testers, need to see the docker worker logs):
Checking login after created a new discipline:
Checking login after creating a new collection: