Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Updated dependency github.com/golang-jwt/jwt to v5.

Module Package Old Version New Version Status
tavern/ github.com/golang-jwt/jwt v3.2.2+incompatible v5.3.0 Build Passed / Fixed Breaking Change

Transitive dependencies updated:

  • github.com/golang-jwt/jwt/v5 added as direct dependency.

PR created automatically by Jules for task 5143406068644040493 started by @KCarretto

Updated the `github.com/golang-jwt/jwt` dependency from `v3.2.2+incompatible` to `v5.2.1` to address potential security vulnerabilities and deprecated features.
Refactored `tavern/internal/c2/server.go` and `tavern/internal/auth/oauth.go` to use the new v5 API, specifically:
- Replacing `jwt.StandardClaims` with `jwt.RegisteredClaims`.
- Wrapping time fields (`IssuedAt`, `ExpiresAt`) with `jwt.NewNumericDate`.
- Updating field accessors (e.g., `Id` to `ID`).
Verified build and tests pass for affected modules.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2342    ±0 2340    ±0 2    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#553 2342 2340 2 0 0 0 28.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2342 0 2 1m 6s

Fail Rate

Fail Rate 0.09%    ±0
Test 📝 Results 📊 Passed ✅ Failed ❌ Fail Rate (%) 📈
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 2 1 33.33    ↑33.33
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 3 2 1 33.33    ↑33.33
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 2 1 33.33    ↑33.33
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 3 2 1 33.33    ↑33.33
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 2 1 33.33    ↑33.33
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 3 2 1 33.33    ↑33.33

Failed Tests

Failed Tests
❌ eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy
Error: deadline has elapsed

Trace:

Error: deadline has elapsed
❌ eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec
Error: deadline has elapsed

Trace:

Error: deadline has elapsed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 3 23.4s 1m 6s
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 3 23.4s 1m 6s
eldritch: pivot::ssh_exec_impl::tests::test_pivot_ssh_exec 3 23.4s 1m 6s
eldritch: process::info_impl::tests::test_info_default 3 2.9s 8.2s
eldritch: process::info_impl::tests::test_info_default 3 2.9s 8.2s
eldritch: process::info_impl::tests::test_info_default 3 2.9s 8.2s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.3s 6.9s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.3s 6.9s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 2.3s 6.9s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 3.6s 6.8s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant