feat: Add translation for pages' titles - #502
Open
Grokafar wants to merge 8 commits into
Open
Conversation
Grokafar
marked this pull request as draft
February 18, 2026 09:45
Author
|
I just see that an issue has been raised about few months ago: #325 |
Grokafar
marked this pull request as ready for review
February 18, 2026 12:30
Author
|
Tested on local docker and seems working 👌 |
Ecklebe
pushed a commit
to Ecklebe/spliit
that referenced
this pull request
Jul 19, 2026
Ecklebe
pushed a commit
to Ecklebe/spliit
that referenced
this pull request
Jul 19, 2026
…mage width/height) Both logo <Image> instances in layout.tsx set explicit width/height props (the intended small ~35px-tall logo) but also carried Tailwind's h-auto w-auto utility classes. CSS wins over HTML width/height attributes for rendering size, so the browser fell back to the source PNG's raw intrinsic pixel dimensions - rendering both the header and footer logo enormous (confirmed visually via a Playwright screenshot before/after, not just from reading the code). This predates all of our merges - it's already present verbatim in the code at our exact pinned base tag (1.19.1/d3b151e), so it isn't something spliit-app#261 or spliit-app#502 introduced, just something that became more noticeable once those PRs added more content around the logos.
4 tasks
Author
|
Perfect ! NP, I'm not a high level TS developer :P Thanks ! The maintainer seems not very active currently :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: the html titles are not translated.
This PR aims to use translations for the HTML pages' titles.
Resolves #325