fix: generate Swagger artifacts independently of UCC test selection#520
Open
rasteja wants to merge 1 commit into
Open
fix: generate Swagger artifacts independently of UCC test selection#520rasteja wants to merge 1 commit into
rasteja wants to merge 1 commit into
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing Swagger client artifacts when an add-on contains UCC modinput tests but that GitHub run does not select
UCC modinput test execution.
Root cause
Swagger/OpenAPI artifact upload was gated by
execute-ucc_modinput. For builds where UCC tests were skipped,swagger_clientwas never generated or uploaded to the build-specific S3 prefix. TACO later failed with:ModuleNotFoundError: No module named swagger_clientChanges
tests/ucc_modinput_functional.artifact-openapibased on that capability, rather than the UCC test-selection flag.Impact
Builds for add-ons with UCC modinput tests now publish the Swagger artifact required by TACO even when the GitHub UCC
test job is skipped.
Validation
Related
swagger_client/__init__.pyis absent.Checklist
README.mdhas been updated or is not requiredTesting done
(for each selected checkbox, the corresponding test results link should be listed here)