fix: remove splunk-cim-models references from documentation - #965
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03044a1211
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| To run **CIM compatibility tests** you also need the CIM data models package: | ||
|
|
||
| ```console | ||
| pip3 install splunk-cim-models | ||
| ``` | ||
|
|
||
| `splunk-cim-models` is versioned independently of `pytest-splunk-addon` so that CIM | ||
| definitions can be updated without a full PSA release. See the |
There was a problem hiding this comment.
After deleting the package name and command, the installation section still says that CIM tests need “the CIM data models package” without identifying how to obtain it, and the following paragraph now begins mid-sentence with “definitions can be updated.” This leaves the primary setup instructions incomplete and grammatically broken; either remove this entire block or retain the package name and installation guidance.
Useful? React with 👍 / 👎.
mkolasinski-splunk
changed the title
2 participants
splunk-cim-models remains private package. Recently it was observed, that a package with same name was published on public PyPI - as a follow up this PR is adjusting all references across documentation to highlight that public splunk-cim-models is not supposed to be used with PSA.