Skip to content

fix(deps): require idna >=3.15 for VULN-88794#122

Merged
shuningc merged 1 commit into
mainfrom
VULN-88794-idna-upgrade
Jul 24, 2026
Merged

fix(deps): require idna >=3.15 for VULN-88794#122
shuningc merged 1 commit into
mainfrom
VULN-88794-idna-upgrade

Conversation

@shuningc

Copy link
Copy Markdown
Contributor

Summary

  • Address VULN-88794 / CVE-2024-3651 follow-up: require idna >= 3.15 (DoS via idna.encode() on crafted long inputs; fixes incomplete in 3.10).
  • Root poetry.lock resolves to 3.18.
  • Previously locked at 3.10 transitively (httpx / requests / yarl, etc.).

Changes

  • Add direct idna = ">=3.15,<4" in pyproject.toml.
  • Refresh poetry.lock (idna 3.10 → 3.18).
  • Bump example pins to idna==3.15 (minimum fixed) where pinned.
  • Update examples/agent/langgraph-fsi-agent/before/poetry.lock for idna 3.18.

Verification

  • poetry check
  • poetry lock (no drift)
  • poetry run pytest tests/ — 1988 passed, 10 skipped
  • PyPI hashes for idna 3.18 match lockfile

Test plan

  • CI green

Jira

  • VULN-88794

@etserend

Copy link
Copy Markdown
Contributor

Code Review — AI-Assisted Feedback

Reviewed by Claude Code (Claude Opus), automated review to assist human reviewers.

Verdict: Approve with comments

Minimal, well-scoped CVE fix. One minor version drift noted below.


P3 — Example pins on minimum fixed version (3.15) while lockfile resolves to 3.18 (Claude Code)

File/Section: examples/agent/minimal-agent-example/requirements.txt (and other example requirements files)
Issue: Example requirements files pin idna==3.15 (the minimum version that fixes CVE-2024-3651), while the root poetry.lock resolves to 3.18. Both are safe, but the inconsistency could cause mild confusion in future audits.
Evidence: examples/agent/minimal-agent-example/requirements.txt: idna==3.15 vs poetry.lock: version = "3.18".
Recommended fix: Optional — align example pins to idna==3.18 for uniformity, or document the rationale for using the minimum-fixed pin in examples.


Reviewer Model Key Contribution
Claude Code Claude Opus Flagged version drift between example pins and root lockfile

etserend
etserend previously approved these changes Jul 24, 2026
Pin idna >=3.15,<4 for DoS remediation; lock resolves 3.18. Example pins
updated to 3.15. Rebased onto current main (includes filelock floor).

Co-authored-by: Cursor <cursoragent@cursor.com>
@shuningc
shuningc force-pushed the VULN-88794-idna-upgrade branch from 6421d75 to 038d66b Compare July 24, 2026 22:13
@etserend
etserend self-requested a review July 24, 2026 22:18
@shuningc
shuningc merged commit 68b03f1 into main Jul 24, 2026
13 checks passed
@shuningc
shuningc deleted the VULN-88794-idna-upgrade branch July 24, 2026 22:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants