fix(deps): require idna >=3.15 for VULN-88794#122
Merged
Conversation
Contributor
Code Review — AI-Assisted Feedback
Verdict: Approve with commentsMinimal, well-scoped CVE fix. One minor version drift noted below. P3 — Example pins on minimum fixed version (3.15) while lockfile resolves to 3.18 (Claude Code)File/Section:
|
etserend
previously approved these changes
Jul 24, 2026
Pin idna >=3.15,<4 for DoS remediation; lock resolves 3.18. Example pins updated to 3.15. Rebased onto current main (includes filelock floor). Co-authored-by: Cursor <cursoragent@cursor.com>
shuningc
force-pushed
the
VULN-88794-idna-upgrade
branch
from
July 24, 2026 22:13
6421d75 to
038d66b
Compare
etserend
self-requested a review
July 24, 2026 22:18
etserend
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idna >= 3.15(DoS viaidna.encode()on crafted long inputs; fixes incomplete in 3.10).poetry.lockresolves to 3.18.Changes
idna = ">=3.15,<4"inpyproject.toml.poetry.lock(idna3.10 → 3.18).idna==3.15(minimum fixed) where pinned.examples/agent/langgraph-fsi-agent/before/poetry.lockforidna3.18.Verification
poetry checkpoetry lock(no drift)poetry run pytest tests/— 1988 passed, 10 skippedidna3.18 match lockfileTest plan
Jira