Fix intermediate frames trimming to make sure final notes output is not truncated #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue highlighted in a different PR by @avan06 (thanks!).
The original lines
trim the output frames a bit more than appropriate.
The root cause is that
ANNOTATIONS_FPS, which represents the number of expected output frames per second, is rounded down to the next integer, dropping the few samples of the last incomplete frame. This makesaudio_original_length * (ANNOTATIONS_FPS / AUDIO_SAMPLE_RATE))underestimates the number of frames needed in the output (not much per frame, but it compounds to several seconds of audio when analysing audios that are >10mn long)The PR adds a test to make sure that the last frame second (as computed downstream in the pipeline) is close to the actual audio length. (additionally, it would be nice to add a test for the
model_frames_to_timemethod)