Skip to content

Adding Vertex AI Imagen models support#2144

Closed
Marzouki-Sami wants to merge 12 commits into
spring-projects:mainfrom
Marzouki-Sami:gh-2133
Closed

Adding Vertex AI Imagen models support#2144
Marzouki-Sami wants to merge 12 commits into
spring-projects:mainfrom
Marzouki-Sami:gh-2133

Conversation

@Marzouki-Sami

Copy link
Copy Markdown

Closes gh-2133

Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@Marzouki-Sami Marzouki-Sami marked this pull request as draft January 29, 2025 07:07
@Marzouki-Sami Marzouki-Sami marked this pull request as ready for review January 29, 2025 07:12
@markpollack

Copy link
Copy Markdown
Member

@ddobrin can you please take a look?

@turchinc

Copy link
Copy Markdown
Contributor

Any update here? I am also interested in this feature.

@byungjunn

Copy link
Copy Markdown

I am currently using this feature as a custom-made version. I hope it gets updated soon. If help is needed, I would be willing to participate.

@ilayaperumalg

Copy link
Copy Markdown
Member

@byungjunn Thanks! Any help reviewing the PR is much appreciated.

Comment thread spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated
Comment thread spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated
Comment thread spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated
Comment thread spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-imagen/pom.xml Outdated
@byungjunn

Copy link
Copy Markdown

@Marzouki-Sami
https://spring.io/blog/2025/03/25/spring-ai-update-to-snapshots
After the update, there have been many changes, so I think you need to rebase onto the main branch.

Marzouki-Sami and others added 5 commits June 16, 2025 11:09
Closes spring-projectsgh-2133

Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
…gen/pom.xml


Updating the version.

Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
…gen/pom.xml


changing artifactId

Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
…gen/pom.xml


removing unnecessary spaces

Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami

Copy link
Copy Markdown
Author

@byungjunn @ilayaperumalg @markpollack i had some issues with resolving the conflict and to resolve the conflict i had to remove the commits, doing that closed this PR is it possible to reopen it, if not i will create a new PR and link it to this one.

@ilayaperumalg ilayaperumalg reopened this Jun 17, 2025
@Marzouki-Sami Marzouki-Sami force-pushed the gh-2133 branch 2 times, most recently from 7fef979 to 54f3ba7 Compare June 17, 2025 09:47
sami-marzouki-BI and others added 2 commits June 17, 2025 10:49
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
@Marzouki-Sami

Copy link
Copy Markdown
Author

@byungjunn thanks for the review the mentioned points above are fixed. Can you check them?

Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami

Copy link
Copy Markdown
Author

Any updates?

switching constructor params to match only call in VertexAiImagenImageModel.java

Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
@Marzouki-Sami

Copy link
Copy Markdown
Author

Just a minor change added in the last commit (f341567). Switching the constructor params ( mimetype and model) of VertexAiImagenImageGenerationMetadata to be in the same order of usage in VertexAiImagenImageModel ( line 177)

… missing imageOptions

Author: Marzouki-Sami <samymarzouki502@gmail.com>
Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
@Marzouki-Sami

Copy link
Copy Markdown
Author

@byungjunn can you review pls.

@Marzouki-Sami

Copy link
Copy Markdown
Author

@markpollack @ilayaperumalg @ddobrin @byungjunn Any updates? If not, will it take much longer?

@Marzouki-Sami

Copy link
Copy Markdown
Author

@markpollack @ilayaperumalg @ddobrin How much time does it take to get a response on the previous comment?

@Marzouki-Sami

Marzouki-Sami commented Dec 24, 2025

Copy link
Copy Markdown
Author

@byungjunn It has been over four months since I requested a review. Are you still available for review, or should this be passed to another person to review it?

@byungjunn

Copy link
Copy Markdown

@byungjunn It has been over four months since I requested a review. Are you still available for review, or should this be passed to another person to review it?

@Marzouki-Sami Long time no see. I’ve been busy with a lot of things, so we haven’t caught up in a while. I’ve reviewed it enough, and I think it might be better now for the people who actually have the authority to merge to take a look.

@Marzouki-Sami

Copy link
Copy Markdown
Author

@markpollack @ilayaperumalg @ddobrin What’s next? The latest changes have been reviewed and approved by @byungjunn. If another reviewer is needed, please assign one.

Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami

Copy link
Copy Markdown
Author

@markpollack @ilayaperumalg @ddobrin This pull request has been open for over a year without a response to previous mentions. I understand the team may be busy, so if you don't have the capacity to review this at the moment, could you please delegate the review to another team member with write access?

Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami

Copy link
Copy Markdown
Author

@markpollack @ilayaperumalg @ddobrin Another conflict occurred, and there has still been no response to any of the previous comments.

@OreOreDa

Copy link
Copy Markdown

I created another clean PR, in order to solve the issue : #2133
Please have a look

@ddobrin

ddobrin commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Hi @OreOreDa
please note that the Imagen models will be deprecated soon, as per this schedule deprecations.

I would recommend migrating to the Gemini 3.x pro image models beforehand, while using the Google GenAI SDK.

Thank you

cc @ilayaperumalg @sdeleuze

@OreOreDa

OreOreDa commented Jun 5, 2026

Copy link
Copy Markdown

@ddobrin @ilayaperumalg @sdeleuze

My new PR for Google GenAI image models
I integrated the latest refacto, and the latest GenAI sdk updates - tested with "gemini-2.5-flash-image" so far
Can you have a look at it, please ?

Edit: I re created the PR after rebase to the 2.0.0 - congrats for the release, Spring AI is awesome !

@sdeleuze

Copy link
Copy Markdown
Contributor

Closing the PR in favor of #6408.

@sdeleuze sdeleuze closed this Jun 17, 2026
@sdeleuze sdeleuze added the duplicate This issue or pull request already exists label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists image models vertex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: adding Vertex Ai Imagen models support

9 participants