Improve DefaultJobParametersConverter and JsonJobParametersConverter#5457
Open
quaff wants to merge 1 commit into
Open
Improve DefaultJobParametersConverter and JsonJobParametersConverter#5457quaff wants to merge 1 commit into
quaff wants to merge 1 commit into
Conversation
1. let `decode()` supports generics. 2. add `@Nullable` to `JobParameterDefinition`. 3. let `JsonJobParametersConverter` encode `identifying` as boolean instead of String, and add tests to verify both boolean and String can be decoded to java `Boolean`. Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decode()supports generics.@NullabletoJobParameterDefinition.JsonJobParametersConverterencodeidentifyingas boolean instead of String, and add tests to verify both boolean and String can be decoded to javaBoolean.