Open
Conversation
yadij
added
the
S-waiting-for-PR
Contributor
Author
|
Implementing reviewer request from #2249 (comment) Requires PR #2249 to merge first, so leaving as a draft for now. |
Contributor
Author
|
Scope for this PR is adding the |
rousskov
requested changes
Sep 16, 2025
Contributor
There was a problem hiding this comment.
Thank you for posting this draft PR. I think we should focus on Http::Message::packInto() change request first because it alters the overall direction of this work. I left a couple of other comments, but, until the overall direction is settled, addressing other requests would be wasteful.
rousskov
added
the
S-waiting-for-author
yadij
added
S-waiting-for-reviewer
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
yadij
force-pushed
the
arc-mask-sensitive-flag-1
branch
from
8a64e28 to
e3f5995
Compare
yadij
removed
the
S-waiting-for-PR
kinkie
previously approved these changes
Oct 25, 2025
Contributor
kinkie
left a comment
kinkie
left a comment
There was a problem hiding this comment.
Looks like a pretty straightforward refactoring. Go right ahead
to allow for explicit caller controlled redaction of Authentication credentials in generated outputs.
yadij
force-pushed
the
arc-mask-sensitive-flag-1
branch
from
c95d583 to
57f41fc
Compare
kinkie
approved these changes
Nov 9, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to allow for explicit caller controlled redaction of
Authentication credentials in generated outputs.