Skip to content

use user-error to signal errors #45

Closed

Description

@wbolster

first, thanks for this package!

that said, please use (user-error ...) instead or (message ...) to signal errors, so that i can catch them and do something sensible.

this would allow me to write a function that would first try (git-link-commit), falling back to (git-link) in case that fails, which would basically "do what i mean" in 99% of my use cases.

let me know whether i should submit a pr!

Activity

  1. sshaw commented on Jul 26, 2017

    @sshaw
    Owner

    Hi, I only call error in git-link-homepage. messages is most everywhere.

    Can you provide more info? Thanks!

  2. wbolster commented on Jul 26, 2017

    @wbolster
    ContributorAuthor

    yeah, my suggestion is to use (user-error) instead of (message) when something goes wrong. right now you use (message) which does not trigger an error that can be caught.

    i want to be able to do something like this:

        (condition-case nil
            (git-link-commit)
          (user-error
           (git-link)))

    but it seems right now i cannot.

  3. sshaw commented on Jul 27, 2017

    @sshaw
    Owner

    Got it, makes sense. I'll have to look into user-error.

    You may also want to checkout the PRs and issues. There's talk of making a git-link-dwim function or maybe even changing git-link to fallback to git-link-commit.

    I think changing these functions to signal errors will require releasing a 1.0 version.

  4. added this to the v1.0 milestone on Sep 23, 2017
  5. wbolster commented on Jul 9, 2026

    @wbolster
    ContributorAuthor

    hey @sshaw 👋🏼, long time no see 🙃

    i recently noticed that git-link doesn't report errors correctly, looked at the issue tracker, and to my own surprise, it was me who first opened this issue… back in 2017! 🤯

    let's get it fixed once and for all. i just opened #154, so please take a look!

  6. added a commit that references this issue on Jul 25, 2026
    32524ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions