Use single global transaction per process - #798
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a process-wide “global transaction” to avoid starting/rolling back a transaction for every analyzed query, reducing transaction-handling overhead during query reflection and related MySQL schema/query-plan operations.
Changes:
- Add
GlobalTransaction::ensureStarted()and switch query simulation/analyzers to reuse a single transaction. - Remove per-query
beginTransaction()/rollBack()(PDO) andbegin_transaction()/rollback()(mysqli) wrappers from reflectors/analyzers. - Start the global transaction for schema hashing and roll it back via a shutdown handler.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/QueryReflection/PdoPgSqlQueryReflector.php | Uses GlobalTransaction::ensureStarted() instead of per-query transaction begin/rollback. |
| src/QueryReflection/PdoMysqlQueryReflector.php | Uses GlobalTransaction::ensureStarted() instead of per-query transaction begin/rollback. |
| src/QueryReflection/MysqliQueryReflector.php | Uses GlobalTransaction::ensureStarted() instead of per-query transaction begin/rollback. |
| src/QueryReflection/GlobalTransaction.php | New helper to lazily start one transaction and roll it back on shutdown. |
| src/DbSchema/SchemaHasherMysql.php | Starts the global transaction before schema hashing queries. |
| src/Analyzer/QueryPlanAnalyzerMysql.php | Starts the global transaction before EXPLAIN query-plan analysis. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+41
| if (self::$inTransaction) { | ||
| return; | ||
| } | ||
| self::$inTransaction = true; | ||
|
|
||
| try { | ||
| if (QueryReflection::getRuntimeConfiguration()->isAnalyzingWriteQueries()) { | ||
| if ($connection instanceof PDO) { | ||
| $connection->beginTransaction(); | ||
| } else { | ||
| $connection->begin_transaction(); | ||
| } | ||
| } else { | ||
| if ($connection instanceof PDO) { | ||
| $connection->beginTransaction(); | ||
| } else { | ||
| $connection->begin_transaction(\MYSQLI_TRANS_START_READ_ONLY); | ||
| } | ||
| } | ||
| } catch (PDOException $e) { | ||
| // not all drivers may support transactions | ||
| throw new \RuntimeException('Failed to start transaction', $e->getCode(), $e); | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…event transaction poisoning
staabm
marked this pull request as ready for review
July 13, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #797