Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the query reflection cache to explicitly remember successful query validations (not just validation errors), so replay mode can avoid re-validating/recording queries that were already proven valid.
Changes:
- Introduces a
Validmarker type to represent “validated successfully” in cached records. - Updates
ReflectionCacheto store and distinguishValidvsErrorfor validation outcomes, and addscontains()/putValidationSuccess(). - Adjusts
ReplayAndRecordingQueryReflector::validateQueryString()to replay validation only when the query is already present in the cache; otherwise it records and persists the validation result.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Valid.php | Adds a marker type used to persist “validated successfully” state. |
| src/QueryReflection/TypeSerializer.php | Updates record type annotations to allow the new Valid marker. |
| src/QueryReflection/ReplayAndRecordingQueryReflector.php | Uses cache presence to decide between replay vs recording for validation. |
| src/QueryReflection/ReflectionCache.php | Adds schema bump and new APIs to store validation success + query presence. |
| src/QueryReflection/RecordingQueryReflector.php | Records validation success in the cache when no error is returned. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| final class ReflectionCache | ||
| { | ||
| private const SCHEMA_VERSION = 'v12-new-cache5'; | ||
| private const SCHEMA_VERSION = 'v13-valid-query'; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.