fix(stackable-telemetry): Disable ANSI colors when stdout is not a terminal#1183
Merged
fix(stackable-telemetry): Disable ANSI colors when stdout is not a terminal#1183
Conversation
Techassi
requested changes
Mar 30, 2026
Member
Techassi
left a comment
There was a problem hiding this comment.
This should include a changelog entry. Otherwise looks good.
Member
|
I will try to get around to testing this with containerdebug. |
Techassi
approved these changes
Mar 30, 2026
Member
|
Okay I have confirmed that both cargo run -- --output state.json > logs.txt
cargo run -- --output state.jsonproduce the expected output:
This PR can be merged and released which allows us to bump to a never |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlainandJsonconsole log formatsProblem
tracing_subscriber::fmt::layer()enables ANSI colors by default whenever theansifeature is enabled andNO_COLORis unset (source):There is no automatic TTY detection — this is a known upstream issue open since 2021. As a result, containerdebug (and any other consumer of stackable-telemetry) emits raw ANSI codes when running in containers where logs are collected by aggregation systems like Graylog or Vector:
Fix
Explicitly check
std::io::stdout().is_terminal()before configuring the subscriber, so ANSI is only used when writing to an actual terminal.Test plan
cargo check -p stackable-telemetrypasses