-
Notifications
You must be signed in to change notification settings - Fork 166
add feature flags to enable/disable controller groups #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
- Coverage 57.21% 57.16% -0.05%
==========================================
Files 341 341
Lines 34089 34145 +56
==========================================
+ Hits 19503 19519 +16
- Misses 12972 13019 +47
+ Partials 1614 1607 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment
also, it's missing tests and documentation
| } | ||
|
|
||
| // Set up Virtual MCP controllers and webhooks | ||
| if enabledFeatures[featureVMCP] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does it depend only on vmcp enabled? and not on server?
Summary
Adds operator-side feature flags to complement the CRD installation flags from #2809, allowing users to conditionally enable/disable controller groups at runtime.
Changes
ENABLE_SERVER,ENABLE_REGISTRY,ENABLE_VMCPenvironment variables inmain.gosetupControllersAndWebhooksto conditionally start controllers based on flagsoperator.features.server/registry/virtualMCP)Usage
Skip Virtual MCP controllers (matches
crds.install.virtualMcp=false):helm install operator ... --set operator.features.virtualMCP=false
Related
Complements #2809 (CRD installation feature flags)