fix: Ensure Toolhive Errors are Wrapped According to Docs #3171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fmt.Errorf calls to use %w verb instead of %v for error arguments, enabling proper error chain preservation for errors.Is() and errors.As() checks per the error handling documentation. Fixes stacklok#3108 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
- Coverage 57.22% 57.19% -0.03%
==========================================
Files 341 341
Lines 34089 34089
==========================================
- Hits 19507 19497 -10
- Misses 12969 12984 +15
+ Partials 1613 1608 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JAORMX
approved these changes
Jan 2, 2026
eleftherias
approved these changes
Jan 2, 2026
Member
|
Thanks for the PR @majiayu000! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #3108
Changes
pkg/api/v1/workload_service.gopkg/auth/token.gopkg/authz/response_filter.gopkg/mcp/tool_filter.gopkg/networking/utilities.gopkg/secrets/clients/1password.gopkg/vmcp/aggregator/default_aggregator.gopkg/vmcp/discovery/manager.go