fix: Add missing flag shorthands and use shared helpers #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add -g shorthand to --group flag in rm.go (was empty string) - Add -a shorthand to --all flag in stop.go (was missing) - Create AddFormatFlag helper function in common.go with -f shorthand - Create ValidateFormat and ValidateFormatFlag helpers for validation - Create ChainPreRunE helper to combine multiple PreRunE validators - Refactor list.go, registry.go, and mcp.go to use shared AddFormatFlag - Add format validation in PreRunE for all commands with format flags Fixes stacklok#3042 Signed-off-by: majiayu000 <[email protected]>
eleftherias
reviewed
Jan 2, 2026
| func init() { | ||
| listCmd.Flags().BoolVarP(&listAll, "all", "a", false, "Show all workloads (default shows just running)") | ||
| listCmd.Flags().StringVar(&listFormat, "format", FormatText, "Output format (json, text, or mcpservers)") | ||
| AddFormatFlag(listCmd, &listFormat) |
Member
There was a problem hiding this comment.
We should continue to list mcpservers as an allowed format for the thv list command
eleftherias
requested changes
Jan 2, 2026
Member
eleftherias
left a comment
eleftherias
left a comment
There was a problem hiding this comment.
Thanks for the PR @majiayu000. I've left a comment about retaining backward compatibility in the thv list command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #3042
Changes
cmd/thv/app/common.gocmd/thv/app/list.gocmd/thv/app/mcp.gocmd/thv/app/registry.gocmd/thv/app/rm.gocmd/thv/app/stop.go